Skip to content

Commit ea2d5f0

Browse files
committed
Merge #1563: doc: Add convention for defaults
1668564 doc: Add convention for defaults (Tim Ruffing) Pull request description: ACKs for top commit: hebasto: ACK 1668564 jonasnick: ACK 1668564 Tree-SHA512: cb359e20f1944b4095512413df4d55ccd89e1838da8e006cea4e523e6d1d5008afbab4e0d87b05a6e6ad991d1a0003066fc205d15443c8f1eb2b02e13196155a
2 parents ca06e58 + 1668564 commit ea2d5f0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ In addition, libsecp256k1 tries to maintain the following coding conventions:
4949
* Operations involving secret data should be tested for being constant time with respect to the secrets (see [src/ctime_tests.c](src/ctime_tests.c)).
5050
* Local variables containing secret data should be cleared explicitly to try to delete secrets from memory.
5151
* Use `secp256k1_memcmp_var` instead of `memcmp` (see [#823](https://github.com/bitcoin-core/secp256k1/issues/823)).
52+
* As a rule of thumb, the default values for configuration options should target standard desktop machines and align with Bitcoin Core's defaults, and the tests should mostly exercise the default configuration (see [#1549](https://github.com/bitcoin-core/secp256k1/issues/1549#issuecomment-2200559257)).
5253

5354
#### Style conventions
5455

0 commit comments

Comments
 (0)