[401] Fix GitHub adapter bug label detection (#402)

GitHub's markup for issues changed, so that our detection for `bug`
labels no longer worked. This adjusts our selectors, so that we can
figure out whether an issue is labelled as bug or not.

Fixes: #401

Ticket: #401

On the side this also remove support for GH projects.

Projects work differently in GitHub now. They belong to the
user/organization, not to one repository. We need to handle them
differently. The current adapter's implementation does not work any
more.

Author: klappradla

src/core/adapters/github.test.ts

@@ -22,49 +22,27 @@ const pages = {
           <span class="gh-header-number">#12</span>
         </h1>
         <div class="js-issue-labels">
-          <a class="sidebar-labels-style" title="bug">bug</a>
+          <a class="IssueLabel hx_IssueLabel" data-name="bug">bug</a>
         </div>
       </div>`,
     indexpage: `
         <div class="js-check-all-container">
-          <ul>
-            <li id="issue_12" class="js-issue-row selected">
+          <div>
+            <div id="issue_12" class="js-issue-row selected">
               <input type="checkbox" class="js-issues-list-check" name="issues[]" value="12">
               <a href="/bitcrowd/tickety-tick/issues/12" class="h4 js-navigation-open">
                 A Selected GitHub Issue
               </a>
-              <span class="labels">
+              <span class="lh-default">
                 <a href="#" class="IssueLabel">bug</a>
               </span>
-            </li>
-            <li id="issue_11" class="js-issue-row">
+            </div>
+            <div id="issue_11" class="js-issue-row">
               <input type="checkbox" class="js-issues-list-check" name="issues[]" value="11">
               <a href="/bitcrowd/tickety-tick/issues/11" class="h4 js-navigation-open">
                 A GitHub Issue
               </a>
-              <span class="labels"></span>
-            </li>
-          </ul>
-        </div>`,
-    projectpage: `
-        <div class="project-columns">
-          <div class="project-card"
-              data-card-state='["open"]'
-              data-card-label='["enhancement"]'
-              data-card-title='["an","example","feature","ticket","42","#42"]'>
-            <a class="h5">An Example Feature Ticket</a>
-          </div>
-          <div class="project-card"
-              data-card-state='["open"]'
-              data-card-label='["bug"]'
-              data-card-title='["an","example","bug","ticket","43","#43"]'>
-            <a class="h5">An Example Bug Ticket</a>
-          </div>
-          <div class="project-card"
-              data-card-state='["closed"]'
-              data-card-label='["bug"]'
-              data-card-title='["an","example","bug","ticket","which","was","closed","and","should","not","be","found","44","#44"]'>
-            <a class="h5">An Example Bug Ticket which was closed and should not be found</a>
+            </div>
           </div>
         </div>`,
   },
@@ -109,28 +87,6 @@ const pages = {
           </li>
         </ul>
       </div>`,
-
-    projectpage: `
-      <div class="project-columns">
-        <div class="project-card"
-            data-card-state='["open"]'
-            data-card-label='["enhancement"]'
-            data-card-title='["an","example","feature","ticket","42","#42"]'>
-          <a class="h5">An Example Feature Ticket</a>
-        </div>
-        <div class="project-card"
-            data-card-state='["open"]'
-            data-card-label='["bug"]'
-            data-card-title='["an","example","bug","ticket","43","#43"]'>
-          <a class="h5">An Example Bug Ticket</a>
-        </div>
-        <div class="project-card"
-            data-card-state='["closed"]'
-            data-card-label='["bug"]'
-            data-card-title='["an","example","bug","ticket","which","was","closed","and","should","not","be","found","44","#44"]'>
-          <a class="h5">An Example Bug Ticket which was closed and should not be found</a>
-        </div>
-      </div>`,
   },
 };
 
@@ -140,7 +96,6 @@ const url = (path: string) =>
 Object.keys(selectors).forEach((variant) => {
   const html = pages[variant as keyof typeof selectors];
 
-  // eslint-disable-next-line jest/valid-describe
   describe(`github adapter (${variant})`, () => {
     function doc(body = "") {
       const { window } = new JSDOM(`<html><body>${body}</body></html>`);
@@ -187,23 +142,5 @@ Object.keys(selectors).forEach((variant) => {
         },
       ]);
     });
-
-    it("extracts tickets from project pages", async () => {
-      const result = await scan(url("projects/1"), doc(html.projectpage));
-      expect(result).toEqual([
-        {
-          id: "42",
-          title: "An Example Feature Ticket",
-          type: "feature",
-          url: "https://github.com/test-org/test-project/issues/42",
-        },
-        {
-          id: "43",
-          title: "An Example Bug Ticket",
-          type: "bug",
-          url: "https://github.com/test-org/test-project/issues/43",
-        },
-      ]);
-    });
   });
 });

src/core/adapters/github.ts

@@ -18,9 +18,9 @@ import { hasRequiredDetails } from "./utils";
 export const selectors = {
   default: {
     issuesPage: ".js-check-all-container .js-issue-row.selected",
-    issuesPageLabel: ".labels .IssueLabel",
+    issuesPageLabel: ".lh-default .IssueLabel",
     issuePage: ".js-issues-results .gh-header-number",
-    issuePageLabel: '.js-issue-labels .sidebar-labels-style[title="bug"]',
+    issuePageLabel: '.js-issue-labels .IssueLabel[data-name="bug" i]',
   },
   legacy: {
     issuesPage: ".issues-listing .js-issue-row.selected",
@@ -38,16 +38,21 @@ async function attempt(
   if ($has(select.issuesPage, doc)) {
     const issues = $all(select.issuesPage, doc);
 
-    const tickets = issues.map((issue) => {
+    const tickets = issues.reduce((acc, issue) => {
       const id = $value("input.js-issues-list-check", issue);
       const title = $text("a.js-navigation-open", issue);
+
+      if (!id || !title) return acc;
+
       const labels = $all(select.issuesPageLabel, issue);
       const type = labels.some((l) => /bug/i.test(`${l.textContent}`))
         ? "bug"
         : "feature";
 
-      return { id, title, type };
-    });
+      const ticket = { id, title, type };
+      acc.push(ticket);
+      return acc;
+    }, <TicketData[]>[]);
 
     return tickets;
   }
@@ -56,27 +61,11 @@ async function attempt(
   if ($has(select.issuePage, doc)) {
     const id = $text(".gh-header-number", doc)?.replace(/^#/, "");
     const title = $text(".js-issue-title", doc);
-    const type = $has(select.issuePageLabel, doc) ? "bug" : "feature";
-    const tickets = [{ id, title, type }];
-    return tickets;
-  }
 
-  // project page
-  if ($has(".project-columns .project-card", doc)) {
-    const openProjectCardSelector =
-      ".project-columns .project-card[data-card-state='[\"open\"]']";
-    const projectCards = $all(openProjectCardSelector, doc);
-
-    const tickets = projectCards.map((card) => {
-      const id = JSON.parse(card.dataset.cardTitle ?? "null").slice(-2, -1)[0];
-      const type = JSON.parse(card.dataset.cardLabel ?? "null").includes("bug")
-        ? "bug"
-        : "feature";
-      const title = $text("a.h5", card);
-
-      return { id, title, type };
-    });
+    if (!id || !title) return [];
 
+    const type = $has(select.issuePageLabel, doc) ? "bug" : "feature";
+    const tickets = [{ id, title, type }];
     return tickets;
   }