Skip to content

Commit bf3d740

Browse files
JeffyCNbleungatchromium
authored andcommitted
platform/chrome: cros_ec_dev - Use devm_mfd_add_devices
Currently we are calling mfd_add_devices to add devices without matched mfd_remove_devices to remove them. That would cause warning when re-binding cros_ec_dev: [ 123.536192] sysfs: cannot create duplicate filename '/bus/platform/devices/cros- ec-accel.0' [ 123.536210] ------------[ cut here ]------------ [ 123.536223] WARNING: CPU: 3 PID: 156 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x 84 [ 123.536226] Modules linked in: [ 123.536236] CPU: 3 PID: 156 Comm: bash Not tainted 4.13.0-rc3-next-20170731 torvalds#216 [ 123.536238] Hardware name: Google Kevin (DT) [ 123.536242] task: ffffffc0f28bab80 task.stack: ffffffc0f1b30000 [ 123.536247] PC is at sysfs_warn_dup+0x68/0x84 [ 123.536251] LR is at sysfs_warn_dup+0x68/0x84 Signed-off-by: Jeffy Chen <[email protected]> Signed-off-by: Benson Leung <[email protected]>
1 parent aae4e7a commit bf3d740

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/platform/chrome/cros_ec_dev.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,8 +376,8 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec)
376376
id++;
377377
}
378378

379-
ret = mfd_add_devices(ec->dev, 0, sensor_cells, id,
380-
NULL, 0, NULL);
379+
ret = devm_mfd_add_devices(ec->dev, 0, sensor_cells, id,
380+
NULL, 0, NULL);
381381
if (ret)
382382
dev_err(ec->dev, "failed to add EC sensors\n");
383383

0 commit comments

Comments
 (0)