include in find-all-references results

Signed-off-by: Ashley Claymore <[email protected]>

Author: acutmore

src/compiler/checker.ts

@@ -30734,6 +30734,7 @@ namespace ts {
             }
 
             markPropertyAsReferenced(lexicallyScopedSymbol, /* nodeForCheckWriteOnly: */ undefined, /* isThisAccess: */ false);
+            getNodeLinks(node).resolvedSymbol = lexicallyScopedSymbol;
 
             const exp = node.expression;
             let rightType = checkExpression(exp, checkMode);
@@ -38203,6 +38204,15 @@ namespace ts {
                 return resolveEntityName(<Identifier>name, /*meaning*/ SymbolFlags.FunctionScopedVariable);
             }
 
+            if (isPrivateIdentifier(name) && isPrivateIdentifierInInExpression(name.parent)) {
+                const links = getNodeLinks(name.parent);
+                if (links.resolvedSymbol) {
+                    return links.resolvedSymbol;
+                }
+                checkPrivateIdentifierInInExpression(name.parent);
+                return links.resolvedSymbol;
+            }
+
             // Do we want to return undefined here?
             return undefined;
         }

tests/cases/fourslash/findAllRefsPrivateNameProperties.ts

@@ -4,6 +4,7 @@
 ////    [|[|{|"isDefinition": true, "isWriteAccess": true, "contextRangeIndex": 0 |}#foo|] = 10;|]
 ////    constructor() {
 ////        this.[|{|"isWriteAccess": true|}#foo|] = 20;
+////        [|#foo|] in this;
 ////    }
 ////}
 ////class D extends C {
@@ -13,12 +14,12 @@
 ////    }
 ////}
 ////class E {
-////    [|[|{|"isDefinition": true, "contextRangeIndex": 3 |}#foo|]: number;|]
+////    [|[|{|"isDefinition": true, "contextRangeIndex": 4 |}#foo|]: number;|]
 ////    constructor() {
 ////        this.[|{|"isWriteAccess": true|}#foo|] = 20;
 ////    }
 ////}
 
-const [rC0Def, rC0, rC1, rE0Def, rE0, rE1] = test.ranges();
-verify.singleReferenceGroup("(property) C.#foo: number", [rC0, rC1]);
+const [rC0Def, rC0, rC1, rC2, rE0Def, rE0, rE1] = test.ranges();
+verify.singleReferenceGroup("(property) C.#foo: number", [rC0, rC1, rC2]);
 verify.singleReferenceGroup("(property) E.#foo: number", [rE0, rE1]);