Fix: gracefully handle fMP4 segments with missing or partial moof/mdat (#4538)

tarikerkan · web-flow · commit e6a7a87c7faa · 2025-05-25T21:29:53.000+02:00
diff --git a/internal/playback/segment_fmp4.go b/internal/playback/segment_fmp4.go
@@ -193,7 +193,7 @@ func segmentFMP4ReadDurationFromParts(
 		}
 
 		if !bytes.Equal(buf[4:], []byte{'m', 'o', 'o', 'f'}) {
-			return 0, fmt.Errorf("moof box not found")
+			break
 		}
 
 		moofSize := uint32(buf[0])<<24 | uint32(buf[1])<<16 | uint32(buf[2])<<8 | uint32(buf[3])
@@ -209,7 +209,7 @@ func segmentFMP4ReadDurationFromParts(
 		}
 
 		if !bytes.Equal(buf[4:], []byte{'m', 'd', 'a', 't'}) {
-			return 0, fmt.Errorf("mdat box not found")
+			break
 		}
 
 		mdatSize := uint32(buf[0])<<24 | uint32(buf[1])<<16 | uint32(buf[2])<<8 | uint32(buf[3])

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ func segmentFMP4ReadDurationFromParts(`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`if !bytes.Equal(buf[4:], []byte{'m', 'o', 'o', 'f'}) {`
`196`		`- return 0, fmt.Errorf("moof box not found")`
	`196`	`+ break`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`moofSize := uint32(buf[0])<<24 \| uint32(buf[1])<<16 \| uint32(buf[2])<<8 \| uint32(buf[3])`
`@@ -209,7 +209,7 @@ func segmentFMP4ReadDurationFromParts(`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`if !bytes.Equal(buf[4:], []byte{'m', 'd', 'a', 't'}) {`
`212`		`- return 0, fmt.Errorf("mdat box not found")`
	`212`	`+ break`
`213`	`213`	`}`
`214`	`214`
`215`	`215`	`mdatSize := uint32(buf[0])<<24 \| uint32(buf[1])<<16 \| uint32(buf[2])<<8 \| uint32(buf[3])`