Skip to content

Commit 22fbe60

Browse files
marco-ippolitobmeck
authored andcommitted
util: move util.isSymbol to eol
PR-URL: nodejs#52744 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent c24afc2 commit 22fbe60

File tree

4 files changed

+5
-44
lines changed

4 files changed

+5
-44
lines changed

doc/api/deprecations.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1304,6 +1304,9 @@ The `util.isString()` API has been removed. Please use
13041304

13051305
<!-- YAML
13061306
changes:
1307+
- version: REPLACEME
1308+
pr-url: https://github.com/nodejs/node/pull/52744
1309+
description: End-of-Life deprecation.
13071310
- version: v22.0.0
13081311
pr-url: https://github.com/nodejs/node/pull/50488
13091312
description: Runtime deprecation.
@@ -1319,9 +1322,9 @@ changes:
13191322
description: Documentation-only deprecation.
13201323
-->
13211324

1322-
Type: Runtime
1325+
Type: End-of-Life
13231326

1324-
The [`util.isSymbol()`][] API is deprecated. Please use
1327+
The `util.isSymbol()` API has been removed. Please use
13251328
`typeof arg === 'symbol'` instead.
13261329

13271330
### DEP0058: `util.isUndefined()`
@@ -3799,7 +3802,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
37993802
[`util.isObject()`]: util.md#utilisobjectobject
38003803
[`util.isPrimitive()`]: util.md#utilisprimitiveobject
38013804
[`util.isRegExp()`]: util.md#utilisregexpobject
3802-
[`util.isSymbol()`]: util.md#utilissymbolobject
38033805
[`util.isUndefined()`]: util.md#utilisundefinedobject
38043806
[`util.log()`]: util.md#utillogstring
38053807
[`util.promisify`]: util.md#utilpromisifyoriginal

doc/api/util.md

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3140,31 +3140,6 @@ util.isRegExp({});
31403140
// Returns: false
31413141
```
31423142
3143-
### `util.isSymbol(object)`
3144-
3145-
<!-- YAML
3146-
added: v0.11.5
3147-
deprecated: v4.0.0
3148-
-->
3149-
3150-
> Stability: 0 - Deprecated: Use `typeof value === 'symbol'` instead.
3151-
3152-
* `object` {any}
3153-
* Returns: {boolean}
3154-
3155-
Returns `true` if the given `object` is a `Symbol`. Otherwise, returns `false`.
3156-
3157-
```js
3158-
const util = require('node:util');
3159-
3160-
util.isSymbol(5);
3161-
// Returns: false
3162-
util.isSymbol('foo');
3163-
// Returns: false
3164-
util.isSymbol(Symbol('foo'));
3165-
// Returns: true
3166-
```
3167-
31683143
### `util.isUndefined(object)`
31693144
31703145
<!-- YAML

lib/util.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,6 @@ function lazyAbortController() {
9090

9191
let internalDeepEqual;
9292

93-
/**
94-
* @deprecated since v4.0.0
95-
* @param {any} arg
96-
* @returns {arg is symbol}
97-
*/
98-
function isSymbol(arg) {
99-
return typeof arg === 'symbol';
100-
}
101-
10293
/**
10394
* @deprecated since v4.0.0
10495
* @param {any} arg
@@ -381,9 +372,6 @@ module.exports = {
381372
}
382373
return internalDeepEqual(a, b);
383374
},
384-
isSymbol: deprecate(isSymbol,
385-
'The `util.isSymbol` API is deprecated. Please use `arg === "symbol"` instead.',
386-
'DEP0057'),
387375
isUndefined: deprecate(isUndefined,
388376
'The `util.isUndefined` API is deprecated. Please use `arg === undefined` instead.',
389377
'DEP0058'),

test/parallel/test-util.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,6 @@ assert.strictEqual(util.isUndefined(), true);
103103
assert.strictEqual(util.isUndefined(null), false);
104104
assert.strictEqual(util.isUndefined('string'), false);
105105

106-
assert.strictEqual(util.isSymbol(Symbol()), true);
107-
assert.strictEqual(util.isSymbol(), false);
108-
assert.strictEqual(util.isSymbol('string'), false);
109-
110106
assert.strictEqual(util.isFunction(() => {}), true);
111107
assert.strictEqual(util.isFunction(function() {}), true);
112108
assert.strictEqual(util.isFunction(), false);

0 commit comments

Comments
 (0)