Skip to content

Commit 8493aa0

Browse files
authored
Merge pull request #29 from bogosj/mharo/names
Use more descriptive struct field names
2 parents e3261e5 + 58a0e6b commit 8493aa0

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

states.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -124,24 +124,24 @@ type VehicleState struct {
124124
CarVersion string `json:"car_version"`
125125
CenterDisplayState int `json:"center_display_state"`
126126
DarkRims bool `json:"dark_rims"`
127-
Df int `json:"df"`
128-
Dr int `json:"dr"`
127+
DriverFrontDoor int `json:"df"`
128+
DriverRearDoor int `json:"dr"`
129129
ExteriorColor string `json:"exterior_color"`
130-
Ft int `json:"ft"`
130+
FrontTrunk int `json:"ft"`
131131
HasSpoiler bool `json:"has_spoiler"`
132132
Locked bool `json:"locked"`
133133
NotificationsSupported bool `json:"notifications_supported"`
134134
Odometer float64 `json:"odometer"`
135135
ParsedCalendarSupported bool `json:"parsed_calendar_supported"`
136136
PerfConfig string `json:"perf_config"`
137-
Pf int `json:"pf"`
138-
Pr int `json:"pr"`
137+
PassengerFrontDoor int `json:"pf"`
138+
PassengerRearDoor int `json:"pr"`
139139
RearSeatHeaters int `json:"rear_seat_heaters"`
140140
RemoteStart bool `json:"remote_start"`
141141
RemoteStartSupported bool `json:"remote_start_supported"`
142-
Rhd bool `json:"rhd"`
142+
RightHandDrive bool `json:"rhd"`
143143
RoofColor string `json:"roof_color"`
144-
Rt int `json:"rt"`
144+
RearTrunk int `json:"rt"`
145145
SentryMode bool `json:"sentry_mode"`
146146
SentryModeAvailable bool `json:"sentry_mode_available"`
147147
SeatType int `json:"seat_type"`
@@ -153,10 +153,10 @@ type VehicleState struct {
153153
ValetMode bool `json:"valet_mode"`
154154
VehicleName string `json:"vehicle_name"`
155155
WheelType string `json:"wheel_type"`
156-
FdWindow int `json:"fd_window"`
157-
FpWindow int `json:"fp_window"`
158-
RdWindow int `json:"rd_window"`
159-
RpWindow int `json:"rp_window"`
156+
FrontDriverWindow int `json:"fd_window"`
157+
FrontPassengerWindow int `json:"fp_window"`
158+
RearDriverWindow int `json:"rd_window"`
159+
RearPassengerWindow int `json:"rp_window"`
160160
IsUserPresent bool `json:"is_user_present"`
161161
RemoteStartEnabled bool `json:"remote_start_enabled"`
162162
ValetPinNeeded bool `json:"valet_pin_needed"`

states_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func TestStatesSpec(t *testing.T) {
7272
So(err, ShouldBeNil)
7373
So(status.APIVersion, ShouldEqual, 3)
7474
So(status.CalendarSupported, ShouldBeTrue)
75-
So(status.Rt, ShouldEqual, 0)
75+
So(status.RearTrunk, ShouldEqual, 0)
7676
})
7777

7878
Convey("Should get service data", t, func() {

0 commit comments

Comments
 (0)