Support README.adoc as fallback for library descriptions

Author: gregjkal

libraries/models.py

@@ -341,7 +341,7 @@ def get_description(self, client, tag="develop"):
         """
         content = None
         # File paths/names where description data might be stored.
-        files = ["doc/library-detail.adoc", "README.md"]
+        files = ["doc/library-detail.adoc", "README.md", "README.adoc"]
 
         # Try to get the content from the cache first
         static_content_cache = caches["static_content"]

libraries/tests/test_models.py

@@ -1,7 +1,12 @@
 import datetime
+from unittest.mock import MagicMock, patch
+
+import pytest
+from django.core.cache import caches
 from django.db.models import Sum
 from model_bakery import baker
 
+from core.models import RenderedContent
 from libraries.models import CommitAuthor
 from mailing_list.models import EmailData
 
@@ -140,6 +145,37 @@ def test_library_version_first_boost_version_property(library):
     assert library.first_boost_version == version_3
 
 
+DESCRIPTION_FILES = ["doc/library-detail.adoc", "README.md", "README.adoc"]
+
+
+@pytest.mark.parametrize(
+    "first_available, expected",
+    [(0, "<p>adoc</p>"), (1, "<p>md</p>"), (2, "<p>adoc</p>"), (None, None)],
+    ids=["library-detail.adoc", "README.md-fallback", "README.adoc-fallback", "none"],
+)
+@patch("libraries.models.process_md", return_value=("", "<p>md</p>"))
+@patch("libraries.models.write_content_to_tempfile")
+@patch("libraries.models.convert_adoc_to_html", return_value="<p>adoc</p>")
+def test_get_description_file_priority(
+    mock_adoc, mock_tempfile, mock_md, library, first_available, expected
+):
+    """Files are tried in order; the first available file wins."""
+    caches["static_content"].clear()
+    RenderedContent.objects.all().delete()
+    mock_tempfile.return_value.name = "/tmp/fake"
+
+    available = {
+        f: b"content" if first_available is not None and i >= first_available else None
+        for i, f in enumerate(DESCRIPTION_FILES)
+    }
+    client = MagicMock()
+    client.get_file_content.side_effect = (
+        lambda repo_slug, tag, file_path: available.get(file_path)
+    )
+
+    assert library.get_description(client) == expected
+
+
 def test_merge_author_deletes_author():
     author_1_email = baker.make("libraries.CommitAuthorEmail")
     author_1 = author_1_email.author