respect umask for files / dirs (1.2) #6403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this feels a bit dirty considering that it undoes some efforts of chmod'ing it while it has the temp name at least avoids concurrent (and potentially even different) chmods onto the same filename. |
ThomasWaldmann
changed the title
…up#6400 we tried to be very private / secure here, but that created the issue that a less secure umask (like e.g. 0o007) just did not work. to make the umask work, we must start from 0o777 mode and let the umask do its work, like e.g. 0o777 & ~0o007 --> 0o770. with borg's default umask of 0o077, it usually ends up being 0o700, so only permissions for the user (not group, not others).
ThomasWaldmann
force-pushed
the
fix-savefile-mode-1.2
branch
from
7a9ae85 to
f5a47d8
Compare
|
^^^ @enkore @textshell please review. |
ThomasWaldmann
commented
Mar 5, 2022
| def ensure_dir(path, mode=stat.S_IRWXU, pretty_deadly=True): | ||
| def ensure_dir(path, mode=stat.S_IRWXU | stat.S_IRWXG | stat.S_IRWXO, pretty_deadly=True): |
There was a problem hiding this comment.
btw, borg never calls this with the mode parameter, so the default value is always used.
| permissions to the leaf directory | ||
| permissions to the leaf directory. The current umask value is masked out first. |
There was a problem hiding this comment.
^^^ from the os.makedirs docs.
not giving a non-default mode to ensure_dir makes the leaf directory creation consistent with the potential parent directory creation: it just uses 0o777 & ~ umask everywhere (as usual).
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.