Fix false return-type violation for __destruct()

Author: samsonasik

src/Analyser/MethodNode.php

@@ -28,4 +28,9 @@ public function isConstructor(): bool
     {
         return $this->name === '__construct';
     }
+
+    public function isDestructor(): bool
+    {
+        return $this->name === '__destruct';
+    }
 }

src/Rule/Rules/Method/MustHaveReturnTypeRule.php

@@ -45,7 +45,11 @@ public function evaluateAll(ClassNode $classNode): array
         $violations = [];
 
         foreach ($classNode->methods as $method) {
-            if (! $method->isPublic() || $method->isConstructor()) {
+            if (
+                ! $method->isPublic()
+                || $method->isConstructor()
+                || $method->isDestructor()
+            ) {
                 continue;
             }
 

tests/Analyser/MethodNodeTest.php

@@ -14,11 +14,15 @@ final class MethodNodeTest extends TestCase
     public function testMethodHelpers(): void
     {
         $publicConstructor = new MethodNode('__construct', 'public', false, false, 1, 1, 3);
+        $publicDestructor  = new MethodNode('__destruct', 'public', false, false, 0, 1, 3);
         $protectedMethod   = new MethodNode('handle', 'protected', true, false, 0, 1, 2);
 
         $this->assertTrue($publicConstructor->isPublic());
         $this->assertTrue($publicConstructor->isConstructor());
+        $this->assertFalse($publicConstructor->isDestructor());
+        $this->assertTrue($publicDestructor->isDestructor());
         $this->assertFalse($protectedMethod->isPublic());
         $this->assertFalse($protectedMethod->isConstructor());
+        $this->assertFalse($protectedMethod->isDestructor());
     }
 }

tests/Rule/Method/MustHaveReturnTypeRuleTest.php

@@ -82,6 +82,16 @@ public function testIgnoresConstructor(): void
         $this->assertNotInstanceOf(RuleViolation::class, $mustHaveReturnTypeRule->evaluate($classNode));
     }
 
+    public function testIgnoresDestructor(): void
+    {
+        $mustHaveReturnTypeRule = new MustHaveReturnTypeRule(layer: 'Domain');
+        $classNode              = $this->makeNode([
+            $this->method('__destruct', hasReturnType: false),
+        ]);
+
+        $this->assertNotInstanceOf(RuleViolation::class, $mustHaveReturnTypeRule->evaluate($classNode));
+    }
+
     public function testIgnoresPrivateMethods(): void
     {
         $mustHaveReturnTypeRule = new MustHaveReturnTypeRule(layer: 'Domain');