Conversation
|
Verified that @jdizoglio has signed the CLA. Thanks for the pull request! |
| BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelOpen = @"open"; | ||
| BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelCompany = @"company"; | ||
| BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelCollaborators = @"collaborators"; | ||
| BOXSharedLinkAccessLevel *const BOXSharedLinkExpireLinkFileAccess = @"expireLinkFiles"; |
There was a problem hiding this comment.
don't seem like we use them?
| extern BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelOpen; | ||
| extern BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelCompany; | ||
| extern BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelCollaborators; | ||
| extern BOXSharedLinkAccessLevel *const BOXSharedLinkExpireLinkFileAvailable; |
There was a problem hiding this comment.
These aren't quite shared link access levels...
Should these just be separate constants specific to the expiration date?
There was a problem hiding this comment.
In fact, these actually aren't used anywhere either, can we remove them?
| BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelOpen = @"open"; | ||
| BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelCompany = @"company"; | ||
| BOXSharedLinkAccessLevel *const BOXSharedLinkAccessLevelCollaborators = @"collaborators"; | ||
| BOXSharedLinkAccessLevel *const BOXSharedLinkExpireLinkFileAccess = @"expireLinkFiles"; |
There was a problem hiding this comment.
This constant name doesn't actually match the definition above, and is not used anywhere. Can we just remove these?
| */ | ||
| @property (nonatomic, readwrite, assign) BOOL requestAllUserFields; | ||
|
|
||
| @property (nonatomic, readonly, strong) NSString *userID; |
There was a problem hiding this comment.
Should we leave a comment that this property only reports a value if a specific user is requested, and that in the default case where no user is specified the current user is used (but this value will be nil or an empty string)?
There was a problem hiding this comment.
Good point, for a manual construction of the request, setting the userID will have the same impact as the initWithUserID
4 participants
No description provided.