pg@9.0 breaking changes ideas

[brianc]

I'd like to gather feedback on breaking changes to make for pg@9.0. I'd like to start working on getting pg@9.0 out sometime in March so there's plenty of time for ideas!

[brianc]

remove queryQueue

The "query queue" idea shipped w/ the original version of node-postgres some 15 years ago. It gums up the internals of the client a bit, isn't how most database drivers behave, and is just weird. Espesh w/ async/await I don't think its used much at all on purpose. So, my plan is to deprecate it very soon in the pg@8.x branch - if someone adds a query to the client's internal query queue while the client is already executing a query in flight, I'll log a 1 time deprecation warning to the terminal. In 9.x the behavior will change to throw an error if a query is sent while another query is in flight.

[brianc]

update pg-types

Because the version of pg-types I'm using is so many years behind the mainline branch I'm sure there are some breaking changes. I will not ever change the default "timezoneless date parsing" to be a different timezone, so either that needs to get reverted it pg-types 5.x or I'll have to patch over that part. Changing that would be a very subtle breaking change with no way to lint for it as it would be based on database types so I don't think its worth it...even though yeah if I had started out today I would try to align it w/ the way psql returned timezoneless dates. I think there might be 1 or 2 other breaking changes in pg-types. The tests should inform what needs to be reported.

[brianc]

pool.end() does not render the pool unusable afterward.

2 things actually.

1. await pool.end() doesn't properly wait for the pool to end AFAIK, so that should be fixed.
2. I don't see a reason calling await pool.end() couldn't leave the pool in a usable state going forward. This would mostly be backwards compatible, but would make it easy in serverless environments to end the pool when the worker shuts down but still be able to keep a global pool reference which is a common pattern.