Skip to content

Commit 3dfcb33

Browse files
committed
Single source of vale-version with caching
1 parent 20fe39f commit 3dfcb33

4 files changed

Lines changed: 13 additions & 37 deletions

File tree

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
version: 2.1
22
orbs:
3-
code-infra: https://raw.githubusercontent.com/mui/mui-public/3feee347096f50b441cad3087743bd1c5aef8651/.circleci/orbs/code-infra.yml
3+
code-infra: https://raw.githubusercontent.com/mui/mui-public/12844f2b6b11babab17bd3d1f799359ea25d1db7/.circleci/orbs/code-infra.yml
44
aws-cli: circleci/aws-cli@5.4.1
55
aws-s3: circleci/aws-s3@4.1.3
66

.github/workflows/ci.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,14 @@ jobs:
7171
if: ${{ matrix.os == 'ubuntu-latest' }}
7272
id: vale-version
7373
run: |
74-
VERSION=$(pnpm code-infra vale --get-version)
74+
VERSION=$(node -p "(require('./package.json').config && require('./package.json').config.valeVersion) || ''")
7575
echo "vale_version=$VERSION" >> $GITHUB_OUTPUT
76+
- name: Cache Vale binary
77+
if: ${{ matrix.os == 'ubuntu-latest' }}
78+
uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
79+
with:
80+
path: node_modules/.cache/mui-vale
81+
key: ${{ runner.os }}-mui-vale-${{ steps.vale-version.outputs.vale_version }}
7682
- uses: vale-cli/vale-action@d89dee975228ae261d22c15adcd03578634d429c # v2.1.1
7783
continue-on-error: true # GitHub Action flag needed until https://github.com/errata-ai/vale-action/issues/89 is fixed
7884
if: ${{ matrix.os == 'ubuntu-latest' }}

.github/workflows/vale-action.yml

Lines changed: 0 additions & 33 deletions
This file was deleted.

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@
4040
"eslint:ci": "eslint . --report-unused-disable-directives --max-warnings 0",
4141
"stylelint": "stylelint --reportInvalidScopeDisables --reportNeedlessDisables \"docs/**/*.?(c|m)[jt]s?(x)\" \"docs/**/*.css\" --ignore-path .lintignore",
4242
"markdownlint": "markdownlint-cli2 \"**/*.md\"",
43-
"vale:fix": "pnpm code-infra vale sync && git ls-files | grep -E \"\\.(md|mdx)$\" | xargs pnpm code-infra vale --filter='.Level==\"error\"' --auto-fix all",
44-
"valelint": "pnpm code-infra vale sync && git ls-files | grep -E \"\\.(md|mdx)$\" | xargs pnpm code-infra vale --filter='.Level==\"error\"'",
43+
"vale:fix": "pnpm code-infra vale sync --vale-version $npm_package_config_valeVersion && git ls-files | grep -E \"\\.(md|mdx)$\" | xargs pnpm code-infra vale --vale-version $npm_package_config_valeVersion --filter='.Level==\"error\"' --auto-fix all",
44+
"valelint": "pnpm code-infra vale sync --vale-version $npm_package_config_valeVersion && git ls-files | grep -E \"\\.(md|mdx)$\" | xargs pnpm code-infra vale --vale-version $npm_package_config_valeVersion --filter='.Level==\"error\"'",
4545
"prettier": "pretty-quick --ignore-path .lintignore --branch master",
4646
"prettier:all": "prettier --write . --ignore-path .lintignore",
4747
"size:snapshot": "pnpm -F ./test/bundle-size check",
@@ -146,6 +146,9 @@
146146
"vitest-fail-on-console": "0.10.1",
147147
"yargs": "18.0.0"
148148
},
149+
"config": {
150+
"valeVersion": "3.14.1"
151+
},
149152
"packageManager": "pnpm@10.33.0",
150153
"engines": {
151154
"pnpm": "10.33.0",

0 commit comments

Comments
 (0)