Skip to content

Commit 7215de8

Browse files
authored
Optimize url recognition when opening urls in omnibar (#2349)
1 parent 8c005bd commit 7215de8

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

src/content_scripts/ui/omnibar.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,14 +593,28 @@ function createOmnibar(front, clipboard) {
593593
handler = null;
594594
};
595595

596+
self.isUrl = function (input) {
597+
if (input.match(/\s+/)) {
598+
return false;
599+
}
600+
601+
if (input.match(/^https?:\/\//)) {
602+
return true;
603+
}
604+
605+
var regex = /^(?:www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_\+.~#?&\/=]*)$/;
606+
607+
return input.match(regex);
608+
}
609+
596610
self.openFocused = function() {
597611
var ret = false, fi = self.resultsDiv.querySelector('li.focused');
598612
var url;
599613
if (fi) {
600614
url = fi.url;
601615
} else {
602616
url = self.input.value;
603-
if (url.indexOf(':') === -1) {
617+
if (!self.isUrl(url)) {
604618
url = searchEngine.aliases[runtime.conf.defaultSearchEngine].url + url;
605619
}
606620
}

0 commit comments

Comments
 (0)