Skip to content

Conversation

@b0o
Copy link
Collaborator

@b0o b0o commented Nov 13, 2025

To the best of my understanding, this behavior should not be limited to Safari. Is there a good reason that we were previously checking getBrowserName().startsWith("Safari")? If so, I am not sure if this change breaks some previously expected behavior.

Behavior should not be limited to Safari
@brookhong
Copy link
Owner

For other browsers than Safari, the tabbed action will be handled with mouse event, so that it fixed #2299

@b0o
Copy link
Collaborator Author

b0o commented Nov 15, 2025

I see. In Chrome, when using shift while picking a hint, it opens in a new window instead of a new tab, which is what prompted me to make this PR. What do you think the proper fix would be?

@brookhong
Copy link
Owner

I see. In Chrome, when using shift while picking a hint, it opens in a new window instead of a new tab, which is what prompted me to make this PR. What do you think the proper fix would be?

I'm not experiencing this, it just opens in a new tab when using shift. What's your OS? I tested in macOS and Windows 11, it works fine for both.

@b0o
Copy link
Collaborator Author

b0o commented Nov 17, 2025

Hmm. I'm using Chrome on Linux. It's the same behavior as if I shift+click on a link - it opens in a new window.

@b0o
Copy link
Collaborator Author

b0o commented Nov 17, 2025

I just tested Chrome on Windows with my same config, and in that case it opens in a new tab, so something is different about Linux, which is odd.

@b0o
Copy link
Collaborator Author

b0o commented Nov 17, 2025

Ok, for some reason, the issue is not happening anymore. I have no clue what changed. Thanks for looking into it for me on your end!

@b0o b0o closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants