-
-
Notifications
You must be signed in to change notification settings - Fork 185
Please add a .npmignore
#164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
None of these files are useless; See not just #82, but #149 (review), #132 (review), #128 (review), #59 (comment). |
This seems like an extremely niche use case, anyone who wants to run the tests could simply install the github version via: This modules is installed millions of times per week, I highly doubt that even 0.0001% of those installs ever access the test folder. Also this doesn't explain why examples ci, and editorconfig files are bundled. |
When you're offline, you don't have github available to you, but you do have your previously installed node_modules. I'd be fine adding an npmignore for the travis-ci config, if you think those few scant bytes would be an improvement. Examples serve as documentation, and altho the editorconfig isn't currently enforced by tests, that's a check I've meant to add. The reality is that most of this "weight" gets gzipped down to being negligible, so it's just not a real problem in practice. |
See #82
You are shipping dozens of files useless to the consumer:
The text was updated successfully, but these errors were encountered: