Skip to content

Update vulnerable dependency (static-eval) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cp4r3z opened this issue Oct 19, 2017 · 6 comments
Closed

Update vulnerable dependency (static-eval) #34

cp4r3z opened this issue Oct 19, 2017 · 6 comments

Comments

@cp4r3z
Copy link

cp4r3z commented Oct 19, 2017

https://nodesecurity.io/advisories/548

Remediation: Upgrade to static-eval 2.0

@pirosikick
Copy link

👍

@yoshuawuyts
Copy link
Member

PR welcome!

@danez
Copy link

danez commented Oct 20, 2017

Without a changelog of static-eval@2 it is rather hard to figure out what the breaking change is and how it affects this module.

@yoshuawuyts
Copy link
Member

@danez I think if the tests pass we should merge it — it's trading off a known bug against a hypothetical bug; this is a fix.

Agree it'd be nice if we could test this ahead of time on dependents, but we don't have the infra setup for that now, and don't think we should hold off merging this patch until then. Hope this makes sense!

@dyaa
Copy link

dyaa commented Oct 25, 2017

Any updates !

@cp4r3z
Copy link
Author

cp4r3z commented Oct 26, 2017

Looks like PR #36 might also address the problem, but is more involved. Sounds like @lguzzon has the tests succeeding as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants