Revert typing of asyncpg.create_pool() and add test

Refs #121

Author: bryanforbes

asyncpg-stubs/pool.pyi

@@ -519,7 +519,7 @@ class PoolAcquireContext(Generic[_Record]):
     ) -> Generator[Any, None, PoolConnectionProxy[_Record]]: ...
 
 @overload
-async def create_pool(
+def create_pool(
     dsn: str | None = ...,
     *,
     min_size: int = ...,
@@ -546,7 +546,7 @@ async def create_pool(
     server_settings: dict[str, str] | None = ...,
 ) -> Pool[protocol.Record]: ...
 @overload
-async def create_pool(
+def create_pool(
     dsn: str | None = ...,
     *,
     min_size: int = ...,

pyproject.toml

@@ -57,7 +57,7 @@ incremental = true
 strict = true
 
 [tool.pyright]
-include = ["asyncpg-stubs"]
+include = ["asyncpg-stubs", "tests"]
 
 pythonVersion = "3.7"
 reportUnnecessaryTypeIgnoreComment = "warning"

tests/test_pool.py

@@ -0,0 +1,15 @@
+from __future__ import annotations
+
+from typing_extensions import assert_type
+
+import asyncpg
+
+
+async def main() -> None:
+    pool = await asyncpg.create_pool()
+    assert_type(pool, 'asyncpg.Pool[asyncpg.Record] | None')
+    assert pool is not None
+    assert_type(await pool, 'asyncpg.Pool[asyncpg.Record] | None')
+
+    async with asyncpg.create_pool() as pool:
+        assert_type(pool, asyncpg.Pool[asyncpg.Record])