Skip to content

Commit 0fa7c34

Browse files
committed
break out _is_known_property in JailConfig
1 parent 14f3da5 commit 0fa7c34

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

iocage/lib/Config/Jail/JailConfig.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ def _get_host_hostname(self) -> str:
7070
return str(jail.humanreadable_name)
7171
raise e
7272

73+
def _is_known_property(self, key: str) -> bool:
74+
key_is_default = key in self.host.defaults.config.keys()
75+
key_is_setter = f"_set_{key}" in dict.__dir__(self)
76+
key_is_special = key in iocage.lib.Config.Jail.Properties.properties
77+
return (key_is_default or key_is_setter or key_is_special) is True
7378

7479
def __setitem__(
7580
self,
@@ -79,11 +84,7 @@ def __setitem__(
7984
) -> None:
8085
"""Set a configuration value."""
8186
# require the config property to be defined in the defaults
82-
key_is_default = key in self.host.defaults.config.keys()
83-
key_is_setter = f"_set_{key}" in dict.__dir__(self)
84-
key_is_special = key in iocage.lib.Config.Jail.Properties.properties
85-
86-
if (key_is_default or key_is_setter or key_is_special) is False:
87+
if self._is_known_property(key) is False:
8788
err = iocage.lib.errors.UnknownJailConfigProperty(
8889
jail=self.jail,
8990
key=key,

0 commit comments

Comments
 (0)