Skip to content

Cranelift: Wrong result for icmp.i128 eq on aarch64 #4705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afonso360 opened this issue Aug 13, 2022 · 0 comments · Fixed by #4706
Closed

Cranelift: Wrong result for icmp.i128 eq on aarch64 #4705

afonso360 opened this issue Aug 13, 2022 · 0 comments · Fixed by #4706
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator

Comments

@afonso360
Copy link
Contributor

afonso360 commented Aug 13, 2022

👋 Hey,

We found this issue as part of a libcore test in cg_clif. (see: https://github.com/bjorn3/rustc_codegen_cranelift/issues/1256).

.clif Test Case

test run
target aarch64

function %numcore(i128) -> b1 {
block0(v0: i128):
    v1 = iconst.i128 0
    v2 = icmp eq v0, v1
    return v2
}
; run: %numcore(36893488147419103231) == false

Steps to Reproduce

  • clif-util test ./the-above.clif

Expected Results

The test to pass

Actual Results

    Finished dev [unoptimized + debuginfo] target(s) in 0.12s
     Running `/home/ubuntu/git/wasmtime/target/debug/clif-util test ./lmao.clif`
 ERROR cranelift_filetests::concurrent > FAIL: run
FAIL ./lmao.clif: run

Caused by:
    Failed test: run: %numcore(36893488147419103231) == false, actual: true
1 tests
Error: 1 failure

Versions and Environment

Cranelift version or commit: main
Operating system: linux
Architecture: aarch64

cc: @akirilov-arm

@afonso360 afonso360 added bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator labels Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant