Database version Rename#28
Conversation
|
What other modules break by changing the external api for Using a separate version number than the core library that's published on npm might cause confusion later in time. With a small distributed set of contributors, reducing the number of variables at play can help with groking potential bugs or mismatches in versions. What if we used the version from package.json? |
|
|
||
| inherits(Cabal, events.EventEmitter) | ||
| Cabal.prototype.getProtocolVersion = function (cb) { | ||
| Cabal.prototype.getDatabaseVersion = function (cb) { |
There was a problem hiding this comment.
Is the code that changes the ~/.cabal/archives dir name already in master, or can that get into this PR too?
There was a problem hiding this comment.
@noffle it's not in master, but in the multi-cabal pr here cabal-club/cabal-cli#89
(i'm not sure how i would bring it into the cabal-core pr)
There was a problem hiding this comment.
Ah, of course!
My thinking was "gosh it'd be nice if we could get in the db-dir changes so we can test that separately from the multi-cabal work".
i renamed protocol version to database version and used an int to represent it instead as it doesn't make sense to have minor & patch on something like this.
lmk what else we can do here before we merge into master
this will be required for cabal-cli's multi cabal pr