remove package-lock.json#84
Merged
Merged
Conversation
Member
|
Checking the log, it looks like it got re-added on May 1 by @nikolaiwarner. Intentional, or just default config? |
Member
|
Gah sorry that was unintentional! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users install this package with npm, they will not get the versions pinned in the lockfile and will instead get the latest versions matching the semver for dependencies. This makes it very easy for versions between local dev and from
npm installto diverge significantly. The lockfile is also used by CI, so updates to package.json versions have no effect for CI, but including changes to package-lock.json introduces a lot of noise to patches and makes pull requests not trivially composable as it's very easy to introduce merge conflicts with files that are modified by programs.