duplexify must be in object mode for mod streams#95
Merged
1 commit merged intoJun 25, 2020
Merged
Conversation
Contributor
Author
|
PR updated to include a test. |
|
Thanks for the patch! This has been merged into 13.0.2. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR because I am unfamiliar with the testing suite, so it only fixes my problem presently.
The issue is that if you treat
cabal.moderation.listas a read stream instead of utilizing its callback, you get this:Here's an excerpt from the source that triggers the issue:
The problem is, apparently, that duplexify must be in object mode to handle the objects produced by the stream. This is accomplished by changing
duplexify()intoduplexify.obj()