Mark params as unused (facebook#46426)

Douglas Cheong · facebook-github-bot · commit a05f9c677116 · 2024-09-10T14:33:17.000-07:00
Summary: Pull Request resolved: facebook#46426 ## Changelog: [Internal] - Comment out unused params Reviewed By: rshest Differential Revision: D62448755 fbshipit-source-id: da647197994b982f924b2c1330a2b529e48d7ad8
diff --git a/packages/react-native/ReactCommon/react/bridging/Convert.h b/packages/react-native/ReactCommon/react/bridging/Convert.h
@@ -158,12 +158,12 @@ auto convert(jsi::Runtime& rt, std::optional<T> value) {
 }
 
 template <typename T, std::enable_if_t<std::is_scalar_v<T>, int> = 0>
-auto convert(jsi::Runtime& rt, T&& value) {
+auto convert(jsi::Runtime& /*rt*/, T&& value) {
   return value;
 }
 
 template <typename T>
-auto convert(jsi::Runtime& rt, Converter<T>&& converter) {
+auto convert(jsi::Runtime& /*rt*/, Converter<T>&& converter) {
   return std::move(converter);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -158,12 +158,12 @@ auto convert(jsi::Runtime& rt, std::optional<T> value) {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`template <typename T, std::enable_if_t<std::is_scalar_v<T>, int> = 0>`
`161`		`-auto convert(jsi::Runtime& rt, T&& value) {`
	`161`	`+auto convert(jsi::Runtime& /rt/, T&& value) {`
`162`	`162`	`return value;`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`template <typename T>`
`166`		`-auto convert(jsi::Runtime& rt, Converter<T>&& converter) {`
	`166`	`+auto convert(jsi::Runtime& /rt/, Converter<T>&& converter) {`
`167`	`167`	`return std::move(converter);`
`168`	`168`	`}`
`169`	`169`