Skip to content

feat: support image writing for filewrite toolkit #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JINO-ROHIT
Copy link
Collaborator

Links #2441

Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JINO-ROHIT 's contribution, the goal of this issue is to enable embedding images within other file formats, such as PDFs, rather than solely generating standalone image files (e.g., .png), I think I didn't explain it's clearly in the issue, sorry for the confusion

@@ -31,12 +34,13 @@

@MCPServer()
class FileWriteToolkit(BaseToolkit):
r"""A toolkit for creating, writing, and modifying text in files.
"""A toolkit for creating, writing, and modifying text and image files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use r for docstring writing, refer to https://github.com/camel-ai/camel/blob/master/CONTRIBUTING.md#1-use-the-triple-quoted-string-with-r-raw-string

Suggested change
"""A toolkit for creating, writing, and modifying text and image files.
r"""A toolkit for creating, writing, and modifying text and image files.

@Wendong-Fan Wendong-Fan added New Feature Tool Waiting for Update PR has been reviewed, need to be updated based on review comment labels May 24, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 30 milestone May 24, 2025
@Wendong-Fan Wendong-Fan changed the title support image writing for filewrite toolkit feat: support image writing for filewrite toolkit May 24, 2025
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure if agent can use this tool to generate image but generating bytes. Correct me if I am wrong

@zjrwtx
Copy link
Collaborator

zjrwtx commented Jun 6, 2025

hello @JINO-ROHIT ,Does anything block you?please lets us know if you need any help,thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Tool Waiting for Update PR has been reviewed, need to be updated based on review comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Feature Request] FileWriting Toolkit support multi-modal content writing like add image
4 participants