Skip to content

Commit d548b2c

Browse files
XilaiZhangcamsim99
authored andcommitted
[g3 roll] revert flutter#105537 Implement frameData for TestWindow (flutter#107168)
* Revert "Reland "Clipping if only one character text overflows (flutter#99146)" (flutter#102130)" This reverts commit 3f43d9f. * Revert "Implement frameData for TestWindow (flutter#105537)" This reverts commit 21841d7.
1 parent 740c29f commit d548b2c

File tree

3 files changed

+4
-56
lines changed

3 files changed

+4
-56
lines changed

packages/flutter_test/lib/src/binding.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -156,12 +156,6 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
156156
debugDisableShadows = disableShadows;
157157
}
158158

159-
@override
160-
void handleBeginFrame(Duration? rawTimeStamp) {
161-
_window.incrementFrameNumber();
162-
super.handleBeginFrame(rawTimeStamp);
163-
}
164-
165159
@override
166160
TestWindow get window => _window;
167161
final TestWindow _window;
@@ -1054,6 +1048,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
10541048
}
10551049
_phase = newPhase;
10561050
if (hasScheduledFrame) {
1051+
addTime(const Duration(milliseconds: 500));
10571052
_currentFakeAsync!.flushMicrotasks();
10581053
handleBeginFrame(Duration(
10591054
milliseconds: _clock!.now().millisecondsSinceEpoch,
@@ -1098,6 +1093,8 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
10981093
),
10991094
);
11001095

1096+
addTime(additionalTime);
1097+
11011098
return realAsyncZone.run<Future<T?>>(() async {
11021099
_pendingAsyncTasks = Completer<void>();
11031100
T? result;

packages/flutter_test/lib/src/window.dart

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ class TestWindow implements ui.SingletonFlutterWindow {
5959
}) : _window = window,
6060
platformDispatcher = TestPlatformDispatcher(platformDispatcher: window.platformDispatcher);
6161

62-
63-
int _frameNumber = 0;
64-
/// Indicates that the test binding has pumped a frame.
65-
void incrementFrameNumber() {
66-
_frameNumber += 1;
67-
platformDispatcher.frameData = _TestFrameData(_frameNumber);
68-
}
69-
7062
/// The [dart:ui.SingletonFlutterWindow] that is wrapped by this [TestWindow].
7163
final ui.SingletonFlutterWindow _window;
7264

@@ -505,9 +497,6 @@ class TestWindow implements ui.SingletonFlutterWindow {
505497
platformDispatcher.onPlatformMessage = callback;
506498
}
507499

508-
@override
509-
ui.FrameData get frameData => platformDispatcher.frameData;
510-
511500
/// Delete any test value properties that have been set on this [TestWindow]
512501
/// as well as its [platformDispatcher].
513502
///
@@ -522,7 +511,6 @@ class TestWindow implements ui.SingletonFlutterWindow {
522511
clearDisplayFeaturesTestValue();
523512
clearPhysicalSizeTestValue();
524513
clearViewInsetsTestValue();
525-
_frameNumber = 0;
526514
platformDispatcher.clearAllTestValues();
527515
}
528516

@@ -907,7 +895,6 @@ class TestPlatformDispatcher implements ui.PlatformDispatcher {
907895
clearLocalesTestValue();
908896
clearSemanticsEnabledTestValue();
909897
clearTextScaleFactorTestValue();
910-
frameData = const _TestFrameData(0);
911898
}
912899

913900
@override
@@ -940,7 +927,7 @@ class TestPlatformDispatcher implements ui.PlatformDispatcher {
940927
ui.PlatformConfiguration get configuration => _platformDispatcher.configuration;
941928

942929
@override
943-
ui.FrameData frameData = const _TestFrameData(0);
930+
ui.FrameData get frameData => _platformDispatcher.frameData;
944931

945932
@override
946933
ByteData? getPersistentIsolateData() => _platformDispatcher.getPersistentIsolateData();
@@ -956,10 +943,3 @@ class TestPlatformDispatcher implements ui.PlatformDispatcher {
956943
return null;
957944
}
958945
}
959-
960-
class _TestFrameData implements ui.FrameData {
961-
const _TestFrameData(this.frameNumber);
962-
963-
@override
964-
final int frameNumber;
965-
}

packages/flutter_test/test/bindings_test.dart

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -33,35 +33,6 @@ void main() {
3333
});
3434
});
3535

36-
test('frameNumber', () async {
37-
binding.window.clearAllTestValues();
38-
expect(binding.window.frameData.frameNumber, 0);
39-
await binding.runTest(() async {
40-
// runTest pumps a frame.
41-
expect(binding.window.frameData.frameNumber, 1);
42-
43-
// Scheduling should not pump
44-
binding.scheduleFrame();
45-
expect(binding.window.frameData.frameNumber, 1);
46-
binding.handleBeginFrame(null);
47-
expect(binding.window.frameData.frameNumber, 2);
48-
binding.handleDrawFrame();
49-
expect(binding.window.frameData.frameNumber, 2);
50-
51-
// Pump with no scheduled frame.
52-
await binding.pump();
53-
expect(binding.window.frameData.frameNumber, 2);
54-
55-
// Schedule and pump, similar to handleBeginFrame.
56-
binding.scheduleFrame();
57-
await binding.pump();
58-
expect(binding.window.frameData.frameNumber, 3);
59-
}, () {});
60-
binding.postTest();
61-
binding.window.clearAllTestValues();
62-
expect(binding.window.frameData.frameNumber, 0);
63-
});
64-
6536
// The next three tests must run in order -- first using `test`, then `testWidgets`, then `test` again.
6637

6738
int order = 0;

0 commit comments

Comments
 (0)