Skip to content

Commit d9092c5

Browse files
committed
Refactor validation of anchor_rect_list
1 parent 6331314 commit d9092c5

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

shell/platform/windows/client_wrapper/flutter_window_controller.cc

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -530,11 +530,15 @@ void handleCreatePopupWindow(flutter::MethodCall<> const& call,
530530
if (auto const* const anchor_rect_list{
531531
std::get_if<std::vector<flutter::EncodableValue>>(
532532
&anchor_rect_it->second)}) {
533-
if (anchor_rect_list->size() != 4 ||
534-
!std::holds_alternative<int>(anchor_rect_list->at(0)) ||
535-
!std::holds_alternative<int>(anchor_rect_list->at(1)) ||
536-
!std::holds_alternative<int>(anchor_rect_list->at(2)) ||
537-
!std::holds_alternative<int>(anchor_rect_list->at(3))) {
533+
if (anchor_rect_list->size() != 4) {
534+
result->Error(
535+
"INVALID_VALUE",
536+
"Values for 'anchorRect' must be an array of 4 integers.");
537+
return;
538+
} else if (!std::holds_alternative<int>(anchor_rect_list->at(0)) ||
539+
!std::holds_alternative<int>(anchor_rect_list->at(1)) ||
540+
!std::holds_alternative<int>(anchor_rect_list->at(2)) ||
541+
!std::holds_alternative<int>(anchor_rect_list->at(3))) {
538542
result->Error("INVALID_VALUE",
539543
"Values for 'anchorRect' must be of type int.");
540544
return;

0 commit comments

Comments
 (0)