fix(settings): Only update the image source if bootResource.fetch succeeds (#5837)

- Moved `saveUbuntu` and `saveOther` to the `onSuccess` callback of the image source change form
- (driveby) use accessible attributes for testing the form

Fixes [maas-ui#5836](#5836)

Author: ndv99

src/app/settings/views/Images/ChangeSource/ChangeSource.test.tsx

@@ -29,7 +29,9 @@ describe("ChangeSource", () => {
     });
 
     await userEvent
-      .click(screen.getByTestId("auto-sync-switch"))
+      .click(
+        screen.getByRole("checkbox", { name: /Automatically sync images/i })
+      )
       .then(async () => {
         await userEvent.click(screen.getByText("Save"));
       });
@@ -38,6 +40,7 @@ describe("ChangeSource", () => {
     const expectedAction = configActions.update({
       boot_images_auto_import: false,
     });
+
     expect(
       actualActions.find(
         (actualAction) => actualAction.type === expectedAction.type

src/app/settings/views/Images/ChangeSource/ChangeSource.tsx

@@ -63,10 +63,19 @@ const ChangeSource = (): ReactElement => {
   const saved = !saving && previousSaving && !errors;
 
   useWindowTitle("Source");
+  useEffect(() => {
+    dispatch(bootResourceActions.poll({ continuous: false }));
+    dispatch(configActions.fetch());
+    return () => {
+      dispatch(bootResourceActions.pollStop());
+      dispatch(bootResourceActions.cleanup());
+    };
+  }, [dispatch]);
 
   const canChangeSource = resources.every((resource) => !resource.downloading);
   const source: BootResourceUbuntuSource =
     sources !== null &&
+    !!sources.sources[0].source_type &&
     sources.sources[0].source_type === BootResourceSourceType.CUSTOM
       ? sources.sources[0]
       : {
@@ -140,15 +149,6 @@ const ChangeSource = (): ReactElement => {
     }
   }, [sources, resources, otherImages]);
 
-  useEffect(() => {
-    dispatch(bootResourceActions.poll({ continuous: false }));
-    dispatch(configActions.fetch());
-    return () => {
-      dispatch(bootResourceActions.pollStop());
-      dispatch(bootResourceActions.cleanup());
-    };
-  }, [dispatch]);
-
   return (
     <PageContent sidePanelContent={null} sidePanelTitle={null}>
       <ContentSection variant="narrow">
@@ -182,6 +182,8 @@ const ChangeSource = (): ReactElement => {
                     boot_images_auto_import: values.autoSync,
                   })
                 );
+              }}
+              onSuccess={(values) => {
                 dispatch(
                   bootResourceActions.saveUbuntu({
                     keyring_data: values.keyring_data,
@@ -191,7 +193,6 @@ const ChangeSource = (): ReactElement => {
                     osystems: ubuntuSystems,
                   })
                 );
-                dispatch(bootResourceActions.saveUbuntuSuccess());
                 dispatch(
                   bootResourceActions.saveOther({
                     images: otherSystems.map(
@@ -200,7 +201,6 @@ const ChangeSource = (): ReactElement => {
                     ),
                   })
                 );
-                dispatch(bootResourceActions.saveOtherSuccess());
               }}
               saved={saved}
               saving={saving}