fix: [#1851] Moves URL resolution to after checking if module preloading is enabled to prevent URL errors to be thrown when unresolvable (#1851)

Currently, when using relative paths in `<link rel="modulepreload" href="/dist/..." />`, we will get a stable error from `new URL`.

I moved the URL creation below, similar to `preloadResource`. In addition, there is no actual point in creating a `URL` if the `disableJavaScriptFileLoading` or `disableJavaScriptEvaluation` options are enabled.

Co-authored-by: David Ortner <david@ortner.se>

Author: iam-medvedev

packages/happy-dom/src/nodes/html-link-element/HTMLLinkElement.ts

@@ -295,7 +295,6 @@ export default class HTMLLinkElement extends HTMLElement {
 	 * @param url URL.
 	 */
 	async #preloadModule(url: string): Promise<void> {
-		const absoluteURL = new URL(url, this[PropertySymbol.ownerDocument].location.href);
 		const window = this[PropertySymbol.window];
 		const browserFrame = new WindowBrowserContext(window).getBrowserFrame();
 		const browserSettings = new WindowBrowserContext(window).getSettings();
@@ -310,6 +309,8 @@ export default class HTMLLinkElement extends HTMLElement {
 			return;
 		}
 
+		const absoluteURL = new URL(url, this[PropertySymbol.ownerDocument].location.href);
+
 		if (
 			browserSettings.disableErrorCapturing ||
 			browserSettings.errorCapture !== BrowserErrorCaptureEnum.tryAndCatch

packages/happy-dom/test/nodes/html-link-element/HTMLLinkElement.test.ts

@@ -354,6 +354,32 @@ describe('HTMLLinkElement', () => {
 			expect((<Event>(<unknown>loadEvent)).type).toBe('load');
 		});
 
+		it('Skips preloading when "rel" is set to "modulepreload" and the Happy DOM setting "disableJavaScriptFileLoading" is set to "true"', async () => {
+			window = new Window({
+				settings: { disableJavaScriptFileLoading: true }
+			});
+			document = window.document;
+			const link = document.createElement('link');
+
+			expect(() => {
+				link.rel = 'modulepreload';
+				link.href = '/base/js/TestModuleElement.js';
+			}).not.toThrow();
+		});
+
+		it('Skips preloading when "rel" is set to "modulepreload" and the Happy DOM setting "disableJavaScriptEvaluation" is set to "true"', async () => {
+			window = new Window({
+				settings: { disableJavaScriptEvaluation: true }
+			});
+			document = window.document;
+			const link = document.createElement('link');
+
+			expect(() => {
+				link.rel = 'modulepreload';
+				link.href = '/base/js/TestModuleElement.js';
+			}).not.toThrow();
+		});
+
 		it('Preloads modules when "rel" is set to "modulepreload" and only fetches once when preload is ongoing', async () => {
 			const requests: string[] = [];
 			const window = new Window({