Skip to content

Commit 0624391

Browse files
jonmcewenkayman-mk
andauthored
fix: allow changes to "runner_worker.max_jobs" for Docker Autoscaler (#1221)
## Description Remove `min_size` and `max_size` from `ignore_changes` from the ASG for Docker Autoscaler. The reasoning described in the comment was poor; min_size is fixed at zero, so won't change, and max_size should change when runner_worker.max_jobs is changed, and will not cause immediate scale-up. If it causes scale-down, this the logical desired behaviour. --------- Co-authored-by: Matthias Kay <[email protected]>
1 parent fc0a693 commit 0624391

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

docker_autoscaler.tf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,9 @@ resource "aws_autoscaling_group" "autoscaler" {
143143
}
144144

145145
lifecycle {
146-
# do not change these values as we would immediately scale up/down, which is not wanted
146+
# do not change desired_capacity as this is controlled at runtime by the runner autoscaler
147147
ignore_changes = [
148-
desired_capacity,
149-
min_size,
150-
max_size
148+
desired_capacity
151149
]
152150
}
153151
}

0 commit comments

Comments
 (0)