Add support for Symfony/YAML 5.0

Skip tests that fail due to symfony bug
symfony/symfony#34805

fixes #56
close #45

Author: cebe

.travis.yml

@@ -15,14 +15,14 @@ matrix:
       env: YAML=^3.0
     - php: '7.3'
       env: YAML=~4.3.0
-#    - php: '7.3'
-#      env: YAML=^5.0
+    - php: '7.3'
+      env: YAML=^5.0
     - php: '7.4'
       env: YAML=^3.0
     - php: '7.4'
       env: YAML=~4.3.0
-#    - php: '7.4'
-#      env: YAML=^5.0
+    - php: '7.4'
+      env: YAML=^5.0
     - php: nightly
       env: YAML=~4.3.0
     # windows tests
@@ -43,9 +43,10 @@ matrix:
         - ls
       install:
         - php -dextension=/c/tools/php73/ext/php_openssl.dll -dextension=/c/tools/php73/ext/php_mbstring.dll composer.phar install --prefer-dist --no-interaction
+        - php -dextension=/c/tools/php73/ext/php_openssl.dll -dextension=/c/tools/php73/ext/php_mbstring.dll composer.phar require symfony/yaml:"~4.3.0" --prefer-dist --no-interaction
       script: php -dextension=/c/tools/php73/ext/php_openssl.dll -dextension=/c/tools/php73/ext/php_mbstring.dll vendor/phpunit/phpunit/phpunit
 
-  # allow php nightly to fail until https://travis-ci.community/t/php-nightly-now-requires-oniguruma/2237 is fixed
+  # allow php nightly to fail until there is a phpunit version that supports PHP 8 
   allow_failures:
     - php: nightly
 

Makefile

@@ -17,7 +17,7 @@ install:
 	yarn install
 
 test:
-	php $(PHPARGS) vendor/bin/phpunit $(TESTCASE)
+	php $(PHPARGS) vendor/bin/phpunit --verbose $(TESTCASE)
 	php $(PHPARGS) bin/php-openapi validate tests/spec/data/recursion.json
 	php $(PHPARGS) bin/php-openapi validate tests/spec/data/recursion2.yaml
 

composer.json

@@ -20,7 +20,7 @@
 	"require": {
 		"php": ">=7.1.0",
 		"ext-json": "*",
-		"symfony/yaml": "^3.0 | ~4.0.0 | ~4.1.0 | ~4.2.0 | ~4.3.0",
+		"symfony/yaml": "^3.0 | ~4.0.0 | ~4.1.0 | ~4.2.0 | ~4.3.0 | ^5.0",
 		"justinrainbow/json-schema": "^5.0"
 	},
 	"require-dev": {
@@ -41,7 +41,7 @@
 	},
 	"extra": {
 		"branch-alias": {
-			"dev-master": "1.0.x-dev"
+			"dev-master": "1.4.x-dev"
 		}
 	},
 	"bin": [

tests/ReaderTest.php

@@ -94,6 +94,16 @@ private function assertApiContent(\cebe\openapi\spec\OpenApi $openapi)
      */
     public function testSymfonyYamlBugHunt()
     {
+        // skip test on symfony/yaml 5.0 due to bug https://github.com/symfony/symfony/issues/34805
+        $installed = json_decode(file_get_contents(__DIR__ . '/../vendor/composer/installed.json'), true);
+        foreach($installed as $pkg) {
+            if ($pkg['name'] === 'symfony/yaml' && strncmp($pkg['version_normalized'], '5.0', 3) === 0) {
+                $this->markTestSkipped(
+                    'This test is incompatible with symfony/yaml 4.4 and 5.0, see symfony bug https://github.com/symfony/symfony/issues/34805'
+                );
+            }
+        }
+
         $openApiFile = __DIR__ . '/../vendor/oai/openapi-specification/examples/v3.0/uspto.yaml';
         $openapi = \cebe\openapi\Reader::readFromYamlFile($openApiFile);
 

tests/spec/OpenApiTest.php

@@ -183,6 +183,18 @@ public function specProvider()
      */
     public function testSpecs($openApiFile)
     {
+        // skip test on symfony/yaml 5.0 due to bug https://github.com/symfony/symfony/issues/34805
+        if ($openApiFile === 'oai/openapi-specification/examples/v3.0/uspto.yaml') {
+            $installed = json_decode(file_get_contents(__DIR__ . '/../../vendor/composer/installed.json'), true);
+            foreach ($installed as $pkg) {
+                if ($pkg['name'] === 'symfony/yaml' && strncmp($pkg['version_normalized'], '5.0', 3) === 0) {
+                    $this->markTestSkipped(
+                        'This test is incompatible with symfony/yaml 4.4 and 5.0, see symfony bug https://github.com/symfony/symfony/issues/34805'
+                    );
+                }
+            }
+        }
+
         if (strtolower(substr($openApiFile, -5, 5)) === '.json') {
             $json = json_decode(file_get_contents(__DIR__ . '/../../vendor/' . $openApiFile), true);
             $openapi = new OpenApi($json);