Improve Responses resolving references

cebe · cebe · commit a02f958b56e2 · 2022-02-09T13:36:38.000+01:00
fixes #119
diff --git a/src/spec/Responses.php b/src/spec/Responses.php
@@ -242,10 +242,10 @@ public function resolveReferences(ReferenceContext $context = null)
                 /** @var Response|Reference|null $referencedObject */
                 $referencedObject = $response->resolve($context);
                 $this->_responses[$key] = $referencedObject;
-                if (!$referencedObject instanceof Reference && $referencedObject !== null) {
+                if (!$referencedObject instanceof Reference && $referencedObject instanceof SpecObjectInterface) {
                     $referencedObject->resolveReferences();
                 }
-            } else {
+            } elseif ($response instanceof SpecObjectInterface) {
                 $response->resolveReferences($context);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -242,10 +242,10 @@ public function resolveReferences(ReferenceContext $context = null)`
`242`	`242`	`/** @var Response\|Reference\|null $referencedObject */`
`243`	`243`	`$referencedObject = $response->resolve($context);`
`244`	`244`	`$this->_responses[$key] = $referencedObject;`
`245`		`- if (!$referencedObject instanceof Reference && $referencedObject !== null) {`
	`245`	`+ if (!$referencedObject instanceof Reference && $referencedObject instanceof SpecObjectInterface) {`
`246`	`246`	`$referencedObject->resolveReferences();`
`247`	`247`	`}`
`248`		`- } else {`
	`248`	`+ } elseif ($response instanceof SpecObjectInterface) {`
`249`	`249`	`$response->resolveReferences($context);`
`250`	`250`	`}`
`251`	`251`	`}`