Skip to content

Implement automatic resolving of references in referenced files #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cebe opened this issue Nov 22, 2018 · 2 comments
Closed

Implement automatic resolving of references in referenced files #14

cebe opened this issue Nov 22, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@cebe
Copy link
Owner

cebe commented Nov 22, 2018

Currently references in referenced files are only resolved if the base type is known.
@cebe cebe added the enhancement New feature or request label Nov 22, 2018
@cebe
Copy link
Owner Author

cebe commented Nov 22, 2018

php-openapi/src/spec/Reference.php

Lines 113 to 118 in 4a4892d

if ($jsonPointer === '') {
$referencedObject->resolveReferences(new ReferenceContext($referencedObject, $file));
} else {
// TODO resolving references recursively does not work as we do not know the base type of the file at this point
// $referencedObject->resolveReferences(new ReferenceContext($referencedObject, $file));
}

@cebe
Copy link
Owner Author

cebe commented Jun 28, 2019

fixed by 6288f41

@cebe cebe closed this as completed Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cebe