Skip to content

Support PHP 8 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
canvural opened this issue Nov 1, 2020 · 2 comments · Fixed by #83
Closed

Support PHP 8 #81

canvural opened this issue Nov 1, 2020 · 2 comments · Fixed by #83
Milestone

Comments

@canvural
Copy link
Contributor

canvural commented Nov 1, 2020

Hello,

Are there any plans for adding support for PHP 8?

Today I checked what needs to be updated. All dependencies except php-cs-fixer have PHP 8 compatible versions. So the issues I found are:

  1. php-cs-fixer needs to updated. There is an issue about it there. Looks like it's still a work in progress. But as mentioned in the discussion here, it is not really a blocker. PHAR release can be downloaded and used in CI. Or something like https://github.com/bamarni/composer-bin-plugin

  2. Some PHPUnit methods used in tests are deprecated in newer versions. But that's easy to fix I guess.

What are your thoughts?

@cebe
Copy link
Owner

cebe commented Nov 2, 2020

Are there any plans for adding support for PHP 8?

sure :)

@canvural
Copy link
Contributor Author

canvural commented Nov 3, 2020

Ok. So, looking forward to it 👍

@cebe cebe added this to the 1.5.0 milestone Dec 14, 2020
@cebe cebe closed this as completed in #83 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants