Fix panic due to nil queue upon close (#112) (#113)

Co-authored-by: Sergey Melekhin <[email protected]>

Author: FZambia

client.go

@@ -769,8 +769,12 @@ func (c *Client) reader(t transport, disconnectCh chan struct{}) {
 }
 
 func (c *Client) runHandlerSync(fn func()) {
-	waitCh := make(chan struct{})
 	c.mu.RLock()
+	if c.cbQueue == nil {
+		c.mu.RUnlock()
+		return
+	}
+	waitCh := make(chan struct{})
 	c.cbQueue.push(func(delay time.Duration) {
 		defer close(waitCh)
 		fn()
@@ -780,9 +784,15 @@ func (c *Client) runHandlerSync(fn func()) {
 }
 
 func (c *Client) runHandlerAsync(fn func()) {
+	c.mu.RLock()
+	if c.cbQueue == nil {
+		c.mu.RUnlock()
+		return
+	}
 	c.cbQueue.push(func(delay time.Duration) {
 		fn()
 	})
+	c.mu.RUnlock()
 }
 
 func (c *Client) handle(reply *protocol.Reply) {

client_test.go

@@ -334,7 +334,32 @@ func TestSubscription_Unsubscribe(t *testing.T) {
 	select {
 	case <-unsubscribedCh:
 	case <-time.After(3 * time.Second):
-		t.Errorf("timeout waiting for subscribe")
+		t.Errorf("timeout waiting for unsubscribe")
+	}
+}
+
+func TestConcurrentCloseDisconnect(t *testing.T) {
+	// Race condition probability between close and disconnect is small,
+	// so doing a lot of iterations increase chance of reproducing.
+	for i := 0; i < 100; i++ {
+		client := NewJsonClient("ws://localhost:8000/connection/websocket", Config{})
+		client.OnConnecting(func(ConnectingEvent) {})
+		if err := client.Connect(); err != nil {
+			t.Fatalf("failed to connect: %v", err)
+		}
+		sub, err := client.NewSubscription("thechannel", SubscriptionConfig{})
+		if err != nil {
+			t.Fatalf("failed to subscribe: %v", err)
+		}
+		sub.OnUnsubscribed(func(UnsubscribedEvent) {})
+		sub.OnSubscribing(func(SubscribingEvent) {})
+		_ = sub.Subscribe()
+		go client.Close()
+		client.handleDisconnect(&disconnect{
+			Code:      connectingTransportClosed,
+			Reason:    "transport closed",
+			Reconnect: false,
+		})
 	}
 }