Skip to content

Commit 2a612a8

Browse files
committed
default to using only kubeconfig for trust demo cluster
also ensure that permissions are set correctly and use the 'latest' tag for the debian trust package when building a demo cluster Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
1 parent 4dac799 commit 2a612a8

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

Makefile

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ CONTAINER_REGISTRY ?= quay.io/jetstack
3636

3737
GOPROXY ?= https://proxy.golang.org,direct
3838

39+
KUBECONFIG ?= $(BINDIR)/kubeconfig.yaml
40+
3941
# can't use a comma in an argument to a make function, so define a variable instead
4042
_COMMA := ,
4143

@@ -101,9 +103,9 @@ local-images: trust-manager-load trust-package-debian-load ## build container i
101103
.PHONY: kind-load
102104
kind-load: local-images | $(BINDIR)/kind ## same as local-images but also run "kind load docker-image"
103105
$(BINDIR)/kind load docker-image \
106+
--name trust \
104107
$(CONTAINER_REGISTRY)/trust-manager:latest \
105-
$(CONTAINER_REGISTRY)/cert-manager-package-debian:latest$(DEBIAN_TRUST_PACKAGE_SUFFIX) \
106-
--name trust
108+
$(CONTAINER_REGISTRY)/cert-manager-package-debian:latest$(DEBIAN_TRUST_PACKAGE_SUFFIX)
107109

108110
.PHONY: chart
109111
chart: | $(BINDIR)/helm $(BINDIR)/chart
@@ -131,7 +133,7 @@ smoke: demo ## ensure cluster, deploy trust-manager and run smoke tests
131133
${BINDIR}/ginkgo -procs 1 test/smoke/ -- --kubeconfig-path ${BINDIR}/kubeconfig.yaml
132134

133135
$(BINDIR)/kubeconfig.yaml: depend ensure-kind _FORCE | $(BINDIR)
134-
$(BINDIR)/kind get kubeconfig --name trust > $@
136+
$(BINDIR)/kind get kubeconfig --name trust > $@ && chmod 600 $@
135137

136138
.PHONY: ensure-kind
137139
ensure-kind: depend ensure-ci-docker-network ## create a trust-manager kind cluster, if one doesn't already exist
@@ -142,18 +144,18 @@ ensure-kind: depend ensure-ci-docker-network ## create a trust-manager kind clu
142144
fi
143145

144146
.PHONY: ensure-cert-manager
145-
ensure-cert-manager: depend ensure-kind
147+
ensure-cert-manager: depend ensure-kind $(BINDIR)/kubeconfig.yaml
146148
@if $(BINDIR)/helm list --short --namespace cert-manager --selector name=cert-manager | grep -q cert-manager; then \
147149
echo "cert-manager already installed, not trying to reinstall"; \
148150
else \
149151
$(BINDIR)/helm repo add jetstack https://charts.jetstack.io --force-update; \
150-
$(BINDIR)/helm upgrade -i --create-namespace -n cert-manager cert-manager jetstack/cert-manager --set installCRDs=true --wait; \
152+
$(BINDIR)/helm upgrade --kubeconfig $(KUBECONFIG) -i --create-namespace -n cert-manager cert-manager jetstack/cert-manager --set installCRDs=true --wait; \
151153
fi
152154

153155
.PHONY: ensure-trust-manager
154156
ensure-trust-manager: depend ensure-kind kind-load ensure-cert-manager
155157
$(BINDIR)/helm uninstall -n cert-manager trust-manager || :
156-
$(BINDIR)/helm upgrade -i -n cert-manager trust-manager deploy/charts/trust-manager/. --set image.tag=latest --set app.logLevel=2 --wait
158+
$(BINDIR)/helm upgrade --kubeconfig $(KUBECONFIG) -i -n cert-manager trust-manager deploy/charts/trust-manager/. --set image.tag=latest --set defaultTrustPackage.tag=latest$(DEBIAN_TRUST_PACKAGE_SUFFIX) --set app.logLevel=2 --wait
157159

158160
# When running in our CI environment the Docker network's subnet choice
159161
# causees issues with routing.

0 commit comments

Comments
 (0)