Skip to content

Commit 0005660

Browse files
committed
explicitly allow a delta of 0
1 parent 45f8825 commit 0005660

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/chai/core/assertions.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3027,10 +3027,10 @@ function closeTo(expected, delta, msg) {
30273027

30283028
new Assertion(obj, flagMsg, ssfi, true).is.numeric;
30293029
let message = 'A `delta` value is required for `closeTo`';
3030-
if (!delta) throw new AssertionError(flagMsg ? `${flagMsg}: ${message}` : message, undefined, ssfi);
3030+
if (delta == undefined) throw new AssertionError(flagMsg ? `${flagMsg}: ${message}` : message, undefined, ssfi);
30313031
new Assertion(delta, flagMsg, ssfi, true).is.numeric;
30323032
message = 'A `expected` value is required for `closeTo`';
3033-
if (!delta) throw new AssertionError(flagMsg ? `${flagMsg}: ${message}` : message, undefined, ssfi);
3033+
if (expected == undefined) throw new AssertionError(flagMsg ? `${flagMsg}: ${message}` : message, undefined, ssfi);
30343034
new Assertion(expected, flagMsg, ssfi, true).is.numeric;
30353035

30363036
const abs = (x) => x < 0n ? -x : x;

test/assert.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1893,6 +1893,7 @@ describe('assert', function () {
18931893
assert.closeTo(1.5, 1.0, 0.5);
18941894
assert.closeTo(10, 20, 20);
18951895
assert.closeTo(-10, 20, 30);
1896+
assert.closeTo(10, 10, 0);
18961897

18971898
err(function(){
18981899
assert.closeTo(2, 1.0, 0.5, 'blah');

0 commit comments

Comments
 (0)