remove SignedBalance in assets (paritytech#196)

* remove SignedBalance in assets

* fix types json

* remove signedbalance in types_gen

Author: atenjin

scripts/chainx-js/chainx_types_manual.json

@@ -51,12 +51,6 @@
         "order_type": "OrderType",
         "created_at": "BlockNumber"
     },
-    "SignedBalance": {
-        "_enum": {
-            "Negative": "Balance",
-            "Positive": "Balance"
-        }
-    },
     "TotalAssetInfoForRpc": {
         "info": "AssetInfoForRpc",
         "balance": "BTreeMap<AssetType, String>",

scripts/chainx-js/res/chainx_types.json

@@ -1,10 +1,4 @@
 {
-    "SignedBalance": {
-        "_enum": {
-            "Negative": "Balance",
-            "Positive": "Balance"
-        }
-    },
     "AssetType": {
         "_enum": [
             "Usable",

scripts/chainx-js/types_gen.py

@@ -43,7 +43,6 @@ def ctags_has_json_support():
 
 NEW_TYPES = [
     "AssetType",
-    "SignedBalance",
     "Chain",
     "AddrStr",
     "OrderExecutedInfo",
@@ -82,7 +81,6 @@ def ctags_has_json_support():
     "PriceFluctuation",
     "Selector",
     "Side",
-    "SignedBalance",
     "StakingRequirement",
     "Token",
     "TradingHistoryIndex",

xpallets/assets/src/lib.rs

@@ -48,8 +48,8 @@ pub use xpallet_assets_registrar::{AssetInfo, Chain};
 pub use self::traits::{ChainT, OnAssetChanged};
 use self::trigger::AssetChangedTrigger;
 pub use self::types::{
-    AssetErr, AssetRestriction, AssetRestrictions, AssetType, BalanceLock, SignedBalance,
-    TotalAssetInfo, WithdrawalLimit,
+    AssetErr, AssetRestriction, AssetRestrictions, AssetType, BalanceLock, TotalAssetInfo,
+    WithdrawalLimit,
 };
 
 pub type BalanceOf<T> =
@@ -109,14 +109,11 @@ decl_event!(
     pub enum Event<T> where
         <T as frame_system::Trait>::AccountId,
         Balance = BalanceOf<T>,
-        SignedBalance = SignedBalance<T>,
     {
         Move(AssetId, AccountId, AssetType, AccountId, AssetType, Balance),
         Issue(AssetId, AccountId, Balance),
         Destory(AssetId, AccountId, Balance),
         Set(AssetId, AccountId, AssetType, Balance),
-        /// change token balance, SignedBalance mark Positive or Negative
-        Change(AssetId, AccountId, AssetType, SignedBalance),
         /// set AssetRestrictions for an Asset
         SetRestrictions(AssetId, AssetRestrictions),
     }

xpallets/assets/src/types.rs

@@ -14,17 +14,9 @@ pub use chainx_primitives::{Decimals, Desc, Token};
 pub use xp_runtime::Memo;
 use xpallet_assets_registrar::AssetInfo;
 
-use super::{BalanceOf, Error, Trait};
+use super::{Error, Trait};
 use frame_support::traits::LockIdentifier;
 
-#[derive(PartialEq, Eq, Clone, Encode, Decode, RuntimeDebug)]
-pub enum SignedBalance<T: Trait> {
-    /// A positive imbalance (funds have been created but none destroyed).
-    Positive(BalanceOf<T>),
-    /// A negative imbalance (funds have been destroyed but none created).
-    Negative(BalanceOf<T>),
-}
-
 #[derive(PartialEq, PartialOrd, Ord, Eq, Clone, Copy, Encode, Decode, RuntimeDebug)]
 #[cfg_attr(feature = "std", derive(Serialize, Deserialize))]
 pub enum AssetType {