Skip to content

Commit 99d5309

Browse files
Bento007github-actions
andauthored
feat: update ontologies and add punning term removal for CL (#302)
This pull request introduces several updates to the ontology builder workflow and associated assets. The most significant change is the implementation of an automated process to remove "punning" terms from the CL ontology file using the ROBOT tool in Docker, addressing compatibility issues with `owlready2`. Additionally, ontology versions are updated to their latest releases, and the workflow is improved for consistency and reproducibility. **Ontology handling improvements:** * Added a new function `_remove_punning_terms_from_cl` in `all_ontology_generator.py` to automatically remove punning terms from the CL ontology file using the ROBOT tool via Docker, ensuring compatibility with `owlready2` and automating a previously manual step. * Updated the download logic in `all_ontology_generator.py` to invoke the punning term removal step after downloading the CL ontology. * Modified the `Makefile` to pull the required `obolibrary/robot:v1.9.8` Docker image as part of the install process, ensuring the tool is available for ontology processing. * Changed the workflow step in `.github/workflows/generate_all_ontology.yml` to use `make install` instead of a direct `pip install`, ensuring all dependencies (including Docker image) are set up. **Ontology asset updates:** * Updated multiple ontology versions and filenames in `ontology_info.json` to reference the latest releases and correct files (e.g., CL, EFO, MONDO, NCBITaxon, UBERON, FBbt, FBdv, ZFA, WBls, WBbt, and HANCESTRO). [[1]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L12-R33) [[2]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L43-R48) [[3]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L59-R59) [[4]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L68-R73) [[5]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L85-R90) These changes collectively improve the reliability and maintainability of the ontology builder by automating compatibility fixes and keeping ontology data up to date. --------- Co-authored-by: github-actions <[email protected]>
1 parent 799bd08 commit 99d5309

18 files changed

+169
-50
lines changed

.github/workflows/generate_all_ontology.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: install requirements
3737
run: |
3838
cd tools/ontology-builder
39-
pip install -r requirements.txt
39+
make install
4040
- name: setup git
4141
run: |
4242
git config user.name github-actions
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
81d9dacfd7f242a17ebd2636598f92ee418e8041
1+
6feb574af7b4af0fbea6428820648198b1020471
244 KB
Binary file not shown.
1.14 MB
Binary file not shown.
1.95 MB
Binary file not shown.
10.7 KB
Binary file not shown.
-19 Bytes
Binary file not shown.
3 MB
Binary file not shown.
33.1 MB
Binary file not shown.
1.79 MB
Binary file not shown.

0 commit comments

Comments
 (0)