Commit 99d5309
feat: update ontologies and add punning term removal for CL (#302)
This pull request introduces several updates to the ontology builder
workflow and associated assets. The most significant change is the
implementation of an automated process to remove "punning" terms from
the CL ontology file using the ROBOT tool in Docker, addressing
compatibility issues with `owlready2`. Additionally, ontology versions
are updated to their latest releases, and the workflow is improved for
consistency and reproducibility.
**Ontology handling improvements:**
* Added a new function `_remove_punning_terms_from_cl` in
`all_ontology_generator.py` to automatically remove punning terms from
the CL ontology file using the ROBOT tool via Docker, ensuring
compatibility with `owlready2` and automating a previously manual step.
* Updated the download logic in `all_ontology_generator.py` to invoke
the punning term removal step after downloading the CL ontology.
* Modified the `Makefile` to pull the required `obolibrary/robot:v1.9.8`
Docker image as part of the install process, ensuring the tool is
available for ontology processing.
* Changed the workflow step in
`.github/workflows/generate_all_ontology.yml` to use `make install`
instead of a direct `pip install`, ensuring all dependencies (including
Docker image) are set up.
**Ontology asset updates:**
* Updated multiple ontology versions and filenames in
`ontology_info.json` to reference the latest releases and correct files
(e.g., CL, EFO, MONDO, NCBITaxon, UBERON, FBbt, FBdv, ZFA, WBls, WBbt,
and HANCESTRO).
[[1]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L12-R33)
[[2]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L43-R48)
[[3]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L59-R59)
[[4]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L68-R73)
[[5]](diffhunk://#diff-237773e9d64e2aa651a176e2c0e3bb5da1a4edfbf08c8f4ae34228fea1e41148L85-R90)
These changes collectively improve the reliability and maintainability
of the ontology builder by automating compatibility fixes and keeping
ontology data up to date.
---------
Co-authored-by: github-actions <[email protected]>1 parent 799bd08 commit 99d5309
File tree
18 files changed
+169
-50
lines changed- .github/workflows
- api/python
- ontology-assets
- tools/ontology-builder
- src
- tests
18 files changed
+169
-50
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 commit comments