Skip to content

Commit 8c92154

Browse files
authored
Migrate flake8_bugbear rules to unspecified to suggested (#4616)
1 parent dcd2bfa commit 8c92154

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

crates/ruff/src/rules/flake8_bugbear/rules/getattr_with_constant.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,8 @@ pub(crate) fn getattr_with_constant(
6464
}
6565

6666
let mut diagnostic = Diagnostic::new(GetAttrWithConstant, expr.range());
67-
6867
if checker.patch(diagnostic.kind.rule()) {
69-
#[allow(deprecated)]
70-
diagnostic.set_fix(Fix::unspecified(Edit::range_replacement(
68+
diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
7169
checker.generator().expr(&attribute(obj, value)),
7270
expr.range(),
7371
)));

crates/ruff/src/rules/flake8_bugbear/rules/setattr_with_constant.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,8 @@ pub(crate) fn setattr_with_constant(
7979
{
8080
if expr == child.as_ref() {
8181
let mut diagnostic = Diagnostic::new(SetAttrWithConstant, expr.range());
82-
8382
if checker.patch(diagnostic.kind.rule()) {
84-
#[allow(deprecated)]
85-
diagnostic.set_fix(Fix::unspecified(Edit::range_replacement(
83+
diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
8684
assignment(obj, name, value, checker.generator()),
8785
expr.range(),
8886
)));

crates/ruff/src/rules/flake8_bugbear/rules/unused_loop_control_variable.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,7 @@ pub(crate) fn unused_loop_control_variable(checker: &mut Checker, target: &Expr,
160160
.map(|binding_id| &checker.semantic_model().bindings[binding_id])
161161
.all(|binding| !binding.is_used())
162162
{
163-
#[allow(deprecated)]
164-
diagnostic.set_fix(Fix::unspecified(Edit::range_replacement(
163+
diagnostic.set_fix(Fix::suggested(Edit::range_replacement(
165164
rename,
166165
expr.range(),
167166
)));

0 commit comments

Comments
 (0)