Skip to content

calling dc_backup_provider_new twice lacks last error set #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4180
r10s opened this issue Mar 19, 2023 · 0 comments
Closed
Tracked by #4180

calling dc_backup_provider_new twice lacks last error set #4178

r10s opened this issue Mar 19, 2023 · 0 comments

Comments

@r10s
Copy link
Contributor

r10s commented Mar 19, 2023

if the user cancels the creation of backup_provider_new(), UI is supposed to call stop_ongoing_process.

this canceling, however, seems to take some tens of seconds sometimes - if the user attempts to create another backup provider during this time, this fails with the log line There is already another ongoing process running..

however, the logged line is not reported as an error, get_last_error() just reports nothing that could be shown to the user - i assume, we need to call error! instead of ensure! - error sets last error automatically afaik. the issue is probably also true for other ongoing processes, however, did not really appear there.

finally, of course, in addition, also a faster abortion of backup_provider_new() would be nice, but this issue is only about error handling (there could also be other errors)

related to #4007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants