Skip to content

Checked-c-convert: function parameter renamed #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnnaKornfeldSimpson opened this issue Jul 12, 2018 · 2 comments
Closed

Checked-c-convert: function parameter renamed #528

AnnaKornfeldSimpson opened this issue Jul 12, 2018 · 2 comments
Assignees
Labels
bug This labels issues that are bugs.

Comments

@AnnaKornfeldSimpson
Copy link
Collaborator

Several function parameters named "ix" are renamed to "i" by checked-c-convert, but just in the parameter list, not in the function body. This means there's no declaration for the uses of "ix" in the function body and no use of the renamed parameter "i".

Example: parson.checked.c:1542
Original code: parson.c:1542
Error Produced: use of undeclared identifier 'ix'. There is also a warning for unused parameter 'i'

To use this test case:

  • Clone https://github.com/AnnaKornfeldSimpson/parson
  • Check out the snapshotWeUse branch
  • make test to build the original code. make testchecked to build with the copies produced by checked-c-convert.
  • convert.sh runs checked-c-convert on the original code and outputs to *checked* files. If you re-run it, also edit parson.checked.c to use parson.checked.h. convert.sh may need modifications to run in Windows.
  • Compiler errors can be compared with compilerErrors.txt (produced on a Ubuntu system, not sure if it will perfectly match in Windows)
@awruef awruef self-assigned this Jul 16, 2018
@awruef
Copy link
Collaborator

awruef commented Aug 15, 2018

I have a suspicion that I fixed this in a previous PR without knowing, I tried to reproduce now and it did the right thing. I'll investigate more.

@dtarditi dtarditi added the bug This labels issues that are bugs. label Nov 6, 2018
@dtarditi
Copy link
Member

dtarditi commented Sep 2, 2019

The convert tool has been mostly rewritten (see PR #642). Please reopen this issue if it still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This labels issues that are bugs.
Projects
None yet
Development

No branches or pull requests

3 participants