Skip to content

checked-c-convert: Line endings and comments clobbered during conversion #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnnaKornfeldSimpson opened this issue Aug 20, 2018 · 1 comment
Assignees
Labels
bug This labels issues that are bugs.

Comments

@AnnaKornfeldSimpson
Copy link
Collaborator

AnnaKornfeldSimpson commented Aug 20, 2018

This isn't a correctness issue, but it makes debugging correctness issues a bit more difficult.

Original code:

UINT32
foo(
    UINT32           cmdCode,       // IN: Command code
    BYTE            *cmdBuffer,     // OUT: Command buffer 
    INT32            bufCapacity    // IN: Capacity of 'cmdBuffer' in bytes
);

After conversion:
UINT32 foo(UINT32 cmdCode, BYTE *cmdBuffer : itype(_Ptr<BYTE> ) , INT32 bufCapacity);

When looking at the comments, it's pretty clear that the conversion here is not correct, but without the comments it's much more difficult to see.

@dtarditi dtarditi added the bug This labels issues that are bugs. label Nov 6, 2018
@dtarditi
Copy link
Member

dtarditi commented Sep 2, 2019

The convert tool has been mostly rewritten (see PR #642). Please reopen this issue if it still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This labels issues that are bugs.
Projects
None yet
Development

No branches or pull requests

3 participants