Update bounds checking notes#1166
Merged
Merged
Conversation
added 5 commits
August 20, 2021 19:02
…alue in A Only update BlameAssignments and UnknownSrcBounds if the assignment actually changed the bounds of LValueAbstractSet
…into update-bounds-checking-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a minor modification to the notes emitted during bounds checking:
Only one note is emitted per statement per lvalue expression for an expression with unknown bounds being assigned to an lvalue expression.
For example:
Both assignments
p = qandp++assign expressions (qandp + 1respectively) with unknown bounds top. A note will only be emitted for the first assignment. This helps avoid confusion in the note messages - it may be unclear to the user why the expressionp++would result in the note "assigned expression p + 1 with unknown bounds to p".