Skip to content

Separate out windows and non-windows-specific tests for variadic functions#1180

Merged
mgrang merged 2 commits into
masterfrom
fix_varargs_test
Sep 3, 2021
Merged

Separate out windows and non-windows-specific tests for variadic functions#1180
mgrang merged 2 commits into
masterfrom
fix_varargs_test

Conversation

@mgrang

@mgrang mgrang commented Sep 3, 2021

Copy link
Copy Markdown

Some -Wformat error messages are different between linux and windows systems.
We separate out the common tests in variadic-functions.c. The windows-specific
tests are in variadic-functions-win.c and the non-windows tests are in
variadic-functions-non-win.c.

Mandeep Singh Grang added 2 commits September 3, 2021 11:42
…tions

Some -Wformat error messages are different between linux and windows systems.
We separate out the common tests in variadic-functions.c. The windows-specific
tests are in variadic-functions-win.c and the non-windows tests are in
variadic-functions-non-win.c.
@mgrang mgrang requested review from kkjeer and sulekhark September 3, 2021 20:05

@sulekhark sulekhark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kkjeer kkjeer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants