checked-c-convert : Static modifier removed from function declaration when the function has any arguments

[secure-sw-dev-bot]

This issue was copied from checkedc/checkedc-clang#622

---

This is similar to #524, but I found it to be true even when there is no * type. I'll illustrate this issue with an example where the argument is of type int to show that it's not only related to pointers.

Note: the function foo() is there to show that the checked-c-convert does do something on the second example where bar() doesn't change at all.

Example where static is removed:

Original C code:

void foo(void *(*func_ptr) (void *)) {
}

static void bar(int x) {
}

int main() {

  return 0;
}

checked-c-convert output:

void foo(_Ptr<void* (void* )> func_ptr) {
}

void bar(int x) {
}

int main() {

  return 0;
}

Example where static is not removed:

Original C code:

void foo(void *(*func_ptr) (void *)) {
}

static void bar(void) {
}

int main() {

  return 0;
}

checked-c-convert output:

void foo(_Ptr<void* (void* )> func_ptr) {
}

static void bar(void) {
}

int main() {

  return 0;
}

This is also true when there are no arguments passed in to bar()

[secure-sw-dev-bot]

Comment from @dtarditi:

The convert tool has been mostly rewritten (see PR #642). Please reopen this issue if it still exists.