Skip to content

fix: remove script suffix from request inputs#979

Merged
chhoumann merged 1 commit intomasterfrom
vr/977
Nov 8, 2025
Merged

fix: remove script suffix from request inputs#979
chhoumann merged 1 commit intomasterfrom
vr/977

Conversation

@chhoumann
Copy link
Copy Markdown
Owner

@chhoumann chhoumann commented Nov 8, 2025

Summary

  • stop appending "(from script)" to script-provided input labels so the prompts match author intent
  • update the advanced guide to reflect the simpler labeling

Testing

  • bun run build

Summary by CodeRabbit

  • Documentation

    • Updated documentation to reflect current input field labeling behavior.
  • Changes

    • Removed the "(from script)" label suffix from input fields in the modal interface.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
quickadd Ready Ready Preview Nov 8, 2025 8:25am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Nov 8, 2025

Walkthrough

The changes remove the "(from script)" label suffix that was appended to input fields sourced from scripts. Both the implementation in OnePageInputModal and the corresponding documentation note are updated to reflect this removal.

Changes

Cohort / File(s) Summary
Label augmentation removal
src/preflight/OnePageInputModal.ts
Removed conditional logic that appended " (from script)" to field labels when req.source === "script". The decorateLabel function now returns the label unmodified.
Documentation update
docs/docs/Advanced/onePageInputs.md
Removed the note describing the "(from script)" UI label behavior in the modal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • The code change is a straightforward removal of a single conditional label augmentation
  • Clear intent to simplify the UI by removing visual differentiation
  • Verify that no other parts of the codebase depend on the "(from script)" label for detection or processing logic

Poem

🐰 The labels once whispered "(from script)" with pride,
But now they hop quietly, stripped of their guide.
Simpler, cleaner, a gentler display—
One less thing to manage along the way! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing the '(from script)' suffix from request input labels.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vr/977

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48ea32d and 18d3dcb.

📒 Files selected for processing (2)
  • docs/docs/Advanced/onePageInputs.md (0 hunks)
  • src/preflight/OnePageInputModal.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • src/preflight/OnePageInputModal.ts
  • docs/docs/Advanced/onePageInputs.md

Comment @coderabbitai help to get the list of available commands and usage tips.

@chhoumann chhoumann linked an issue Nov 8, 2025 that may be closed by this pull request
@chhoumann chhoumann merged commit 60ec853 into master Nov 8, 2025
4 checks passed
@chhoumann chhoumann deleted the vr/977 branch November 8, 2025 08:27
github-actions Bot pushed a commit that referenced this pull request Nov 8, 2025
# [2.7.0](2.6.0...2.7.0) (2025-11-08)

### Bug Fixes

* format capture tags as YAML arrays ([#974](#974)) ([bc61760](bc61760))
* remove script suffix in request inputs ([#979](#979)) ([60ec853](60ec853))
* stop macros and APIs immediately when cancellations occur ([#976](#976)) ([48ea32d](48ea32d))

### Features

* add git info display to settings for development mode ([#973](#973)) ([e3b2a8b](e3b2a8b))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 8, 2025

🎉 This PR is included in version 2.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 8, 2025

🚀 Release has been published: v2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quickadd API requestInputs: getting rid of (from script)

1 participant