Skip to content

Commit 30c0c68

Browse files
committed
fix(handlers.js): server crash when target ws server closes.
1 parent d185278 commit 30c0c68

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,10 @@ var httpProxyMiddleware = function (context, opts) {
110110
}
111111

112112
function proxyErrorLogger (err, req, res) {
113+
var hostname = (req.hostname || req.host) || (req.headers && req.headers.host) // (node0.10 || node 4/5) || (websocket)
113114
var targetUri = proxyOptions.target.host + req.url;
114-
logger.error('[HPM] Proxy error: %s. %s -> "%s"', err.code, req.hostname, targetUri);
115+
116+
logger.error('[HPM] Proxy error: %s. %s -> "%s"', err.code, hostname, targetUri);
115117
}
116118

117119
};

lib/handlers.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ module.exports = {
44

55
function proxyError (err, req, res) {
66
var host = (req.headers && req.headers.host);
7-
if (!res.headersSent) {
7+
8+
if (res.writeHead && !res.headersSent) {
89
res.writeHead(500);
910
}
11+
1012
res.end('Error occured while trying to proxy to: '+ host + req.url);
1113
};

0 commit comments

Comments
 (0)