Skip to content

Commit c52ff89

Browse files
committed
Address feedback
1 parent 2eff06a commit c52ff89

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/CaliptraSSCoverage.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ After exclusions, the SoC Interface module in Caliptra Core has > 99% coverage o
346346
### Module: axi_dma_top (i_axi_dma)
347347
348348
There are two low-risk coverage holes after applying exclusions:
349-
1. Error injection scenarios: Many command decode scenarios are validated, but some error cases (for malformed DMA descriptors) are not included. These edge cases are unexpected for correct Firmware and, if encountered during firmware development will produce failure signatures that have been evaluated:
349+
1. Error injection scenarios: Many command decode scenarios are validated, but some error cases (for malformed DMA descriptors) are not included. Firmware is required to send correctly configured DMA commands. These edge cases are unexpected for correct Firmware and, if encountered during firmware development will produce failure signatures that have been evaluated:
350350
1. Invalid Route Combo error: Some invalid routes are not covered. Compliant firmware will never encounter these scenarios.
351351
2. Mailbox Lock Error: For transfers into/out of the Mailbox by DMA, mailbox lock must be acquired. Firmware shall not clear the mailbox lock until the transfer has completed. If lock is cleared during a transfer, this error should fire. Risk: Low, since compliant firmware will never do this.
352352
2. Access to DMA registers by SoC via AXI: This is an illegal path. Writes from the AXI interface to any DMA register are blocked using the same logic as in a other SoC interface register blocks. Risk assessment: Low, because the same logic is proven in other blocks.
@@ -357,7 +357,7 @@ Additionally, coverage is incomplete for some don't-care scenarios, such as writ
357357
358358
Test cases are under development for these scenarios:
359359
- All possible command decode error combinations (include a complete matrix for illegal route combinations)
360-
- AXI error injection (this has been informally validated in both simulation and FPGA contexts but is not part of regressions)
360+
- AXI error injection (this has been validated in both simulation and FPGA contexts as part of development and focused local testing, but is not part of regressions)
361361
- SoC access to all DMA registers via AXI to prove access protections
362362
- Attempted writes to DMA registers during DMA operation (to prove immutability of in-progress transactions)
363363
@@ -381,7 +381,7 @@ Coverage is complete after adding exclusions.
381381
382382
### Module: i_sha512_acc_top
383383
384-
Module is unchanged from release version 1.1, which has been proven in simulation, FPGA testing, and production silicon.
384+
Module in release version 1.1 has been proven in simulation, FPGA testing, and production silicon.
385385
386386
### Module: i_soc_ifc_arb
387387

0 commit comments

Comments
 (0)