FunctionalTests: remove ExtraCoverage category

A limited subset of functional tests are marked as belonging to
the ExtraCoverage category, which was introduced in the
microsoft/VFSForGit#1046 PR as an enhancement over the
FullSuiteOnly category from the Azure Repos PR 302803.
The intent was to make the default functional test run faster
by excluding some less-fragile tests.

However, in Scalar, many of these tests are also marked with
NeedsUpdatesForNonVirtualizedMode and therefore do not run at all,
while the ones which remain have been running in CI on the macOS
platform but not Windows, because Scripts/Mac/RunFunctionalTests.sh
passes the --full-suite option.

In order to simplify the CI and functional test framework,
we eliminate the ExtraCoverage category entirely, which
ensures all working tests run on all platforms in CI.

Author: chrisd8088

AuthoringTests.md

@@ -40,10 +40,9 @@ The functional tests are built on NUnit 3, which is available as a set of NuGet
 
 #### Selecting Which Tests are Run
 
-By default, the functional tests run a subset of tests as a quick smoke test for developers.  There are three mutually exclusive arguments that can be passed to the functional tests to change this behavior:
+By default, the functional tests run a subset of tests as a quick smoke test for developers.  There are mutually exclusive arguments that can be passed to the functional tests to change this behavior:
 
 - `--full-suite`: Run all configurations of all functional tests
-- `--extra-only`: Run only those tests marked as "ExtraCoverage" (i.e. the tests that are not run by default)
 - `--windows-only`: Run only the tests marked as being Windows specific
 
 **NOTE** `Scripts\RunFunctionalTests.bat` already uses some of these arguments.  If you run the tests using `RunFunctionalTests.bat` consider locally modifying the script rather than passing these flags as arguments to the script.

Scalar.FunctionalTests/Categories.cs

@@ -2,7 +2,6 @@ namespace Scalar.FunctionalTests
 {
     public static class Categories
     {
-        public const string ExtraCoverage = "ExtraCoverage";
         public const string GitCommands = "GitCommands";
 
         public const string WindowsOnly = "WindowsOnly";

Scalar.FunctionalTests/Program.cs

@@ -69,16 +69,6 @@ public static void Main(string[] args)
             }
             else
             {
-                if (runner.HasCustomArg("--extra-only"))
-                {
-                    Console.WriteLine("Running only the tests marked as ExtraCoverage");
-                    includeCategories.Add(Categories.ExtraCoverage);
-                }
-                else
-                {
-                    excludeCategories.Add(Categories.ExtraCoverage);
-                }
-
                 ScalarTestConfig.FileSystemRunners = FileSystemRunners.FileSystemRunner.DefaultRunners;
             }
 
@@ -92,10 +82,6 @@ public static void Main(string[] args)
                 if (runner.HasCustomArg("--windows-only"))
                 {
                     includeCategories.Add(Categories.WindowsOnly);
-
-                    // RunTests unions all includeCategories.  Remove ExtraCoverage to
-                    // ensure that we only run tests flagged as WindowsOnly
-                    includeCategories.Remove(Categories.ExtraCoverage);
                 }
 
                 excludeCategories.Add(Categories.MacOnly);

Scalar.FunctionalTests/Tests/EnlistmentPerFixture/CacheServerTests.cs

@@ -5,7 +5,6 @@
 namespace Scalar.FunctionalTests.Tests.EnlistmentPerFixture
 {
     [TestFixture]
-    [Category(Categories.ExtraCoverage)]
     public class CacheServerTests : TestsWithEnlistmentPerFixture
     {
         private const string CustomUrl = "https://myCache";

Scalar.FunctionalTests/Tests/EnlistmentPerFixture/FetchStepWithoutSharedCacheTests.cs

@@ -8,7 +8,6 @@
 namespace Scalar.FunctionalTests.Tests.EnlistmentPerFixture
 {
     [TestFixture]
-    [Category(Categories.ExtraCoverage)]
     public class FetchStepWithoutSharedCacheTests : TestsWithEnlistmentPerFixture
     {
         private const string PrefetchPackPrefix = "prefetch";

Scalar.FunctionalTests/Tests/EnlistmentPerFixture/ScalarUpgradeReminderTests.cs

@@ -12,7 +12,6 @@ namespace Scalar.FunctionalTests.Tests.EnlistmentPerFixture
 {
     [TestFixture]
     [NonParallelizable]
-    [Category(Categories.ExtraCoverage)]
     [Category(Categories.WindowsOnly)]
     [Category(Categories.NeedsUpdatesForNonVirtualizedMode)]
     public class UpgradeReminderTests : TestsWithEnlistmentPerFixture

Scalar.FunctionalTests/Tests/MultiEnlistmentTests/ConfigVerbTests.cs

@@ -7,7 +7,6 @@
 namespace Scalar.FunctionalTests.Tests.MultiEnlistmentTests
 {
     [TestFixture]
-    [Category(Categories.ExtraCoverage)]
     [Category(Categories.NeedsUpdatesForNonVirtualizedMode)]
     public class ConfigVerbTests : TestsWithMultiEnlistment
     {